Open
Conversation
The ~925-line Makefile is split into 10 focused files: make/config.mk — release mode, platform detection, STAMPS/TOUCH_STAMP make/sources.mk — all source file enumerations (Rust, Kotlin, Swift, TS) make/ffi.mk — uniffi-bindgen, ffi-library, bindings-* targets make/ios.mk — iOS device/simulator/xcframework targets make/android.mk — Android ARMv7/ARMv8/x86 targets make/jvm.mk — JVM/KMP build and test targets make/ts.mk — TypeScript/WASM build and test targets make/interop.mk — interop binary and test make/docs.mk — documentation generation targets make/fmt.mk — format and lint targets for all languages The top-level Makefile now contains only the include directives, aggregate targets (all/local/bindings/clean), and the lazy-targets machinery with an explanatory comment. Two pre-existing forward-reference bugs are also fixed: SWIFT_FILES and TS_NATIVE/BROWSER_TEST_FILES were defined after their `:=` assignments, making them silently empty. Both are now defined in sources.mk, which is included before the files that use them. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
grep prepends filename: when searching multiple files. Adding -h suppresses that prefix so awk captures the target name correctly. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…k.sh The 55-line inline shell recipe in ios-create-xcframework is moved to a standalone script, consistent with run-ios-tests.sh and run-android-tests.sh. The script locates the repo root via git so it can be run directly from any working directory, not just from Make. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The ifeq branch and stamp-deletion pattern are non-obvious. The new comment explains why both modes exist (CI always-runs vs. local iteration), what the stamp deletion achieves, and where the real test logic lives. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's new in this PR
The
Makefilewas a beast approaching 1000 LOC; too much to hold in my head. This breaks it up a bit into something easier to work with.PR Submission Checklist for internal contributors
SQPIT-764feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.