ci: publish image for testservice [WPB-21987]#3758
Closed
markbrockhoff wants to merge 1 commit into
Closed
Conversation
|
|
f865d1b to
e89957d
Compare
e89957d to
6376647
Compare
|
Contributor
Author
|
PR was closed in favor of #3759 since I'm not able to run CI for a PR from a fork |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
The e2e tests of the wire webapp use the testservice in some test cases. Currently it manually builds it for each test execution.
Solutions
To save on CI time and resources a docker image with the prebuilt testservice should be published for others to just consume.
Testing
How to Test
You can build and run the new docker image on your system using the following commands:
Notes (Optional)
The PR is currently set up to execute the new Workflow for the PR. This is to test it before merging. Once it ran once successfully I'll remove the pull_request trigger.
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.