refactor: persistence snapshot reads and mention filtering [WPB-8645]#4177
Open
MohamadJaara wants to merge 2 commits into
Open
refactor: persistence snapshot reads and mention filtering [WPB-8645]#4177MohamadJaara wants to merge 2 commits into
MohamadJaara wants to merge 2 commits into
Conversation
Contributor
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #4177 +/- ##
=============================================
- Coverage 61.60% 61.59% -0.01%
- Complexity 4033 4040 +7
=============================================
Files 2076 2077 +1
Lines 67813 67838 +25
Branches 6703 6703
=============================================
+ Hits 41775 41788 +13
- Misses 23369 23380 +11
- Partials 2669 2670 +1
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Contributor
d4c0199 to
1b613b6
Compare
c3097d4 to
900781e
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



https://wearezeta.atlassian.net/browse/WPB-8645
Why
Kalium-owned per-key
FlowCachecan make correctness-sensitive reads depend on replayed observation state. This PR removes that shared cache layer from persistence and adds narrow snapshot reads for fresh database decisions.It also exposes member mention filtering so app-side callers can reuse an already observed member list without collecting the members flow again.
What changed
FlowCacheand its database-builder wiring..first()on observed flows.MembersToMentionUseCase.filterConversationMembers(...)for app-side member snapshot reuse.