Feat: Use composite messages to improve UX WPB-17856

[olanokhin]

---

PR Submission Checklist for internal contributors

• The PR Title

  • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
  • contains a reference JIRA issue number like SQPIT-764
  • answers the question: If merged, this PR will: ... ³

• The PR Description

  • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

---

What's new in this PR?

Issues

• The bot did not support interactive actions, such as deleting a reminder by clicking a button.
• Creating recurring reminders for "every day" would fail with a ParseException due to an invalid cron string format.
• A race condition could cause duplicate key errors when a user retried a failed reminder creation command.
• The /remind list command displayed incorrect text for daily reminders (e.g., "every month" instead of "every day").
• Several code quality warnings were present, including swallowed exceptions and unused variables.

Causes (Optional)

• The application lacked handlers for BUTTON_ACTION events from the messaging platform.
• The CronInterpreter generated cron strings for "every day" (* * *) that were incompatible with the Quartz scheduler, which requires one of the day fields (day-of-month or day-of-week) to be ?.
• The logic to convert cron strings back to text (cronToText) was incorrectly identifying the pattern for "every day".
• In the handleNewReminder flow, the reminder was saved to the database before the confirmation message was generated. If message generation failed (due to the invalid cron), an exception was thrown, but the saved data remained, leading to a duplicate key error on retry.
• Exception handling in some parts of the code was too broad or swallowed exceptions, hiding the root cause of failures.

Solutions

• Button Action for Deletion: Implemented a full flow to handle BUTTON_ACTION events. When a "Delete" button is clicked, the bot now correctly identifies the reminder, deletes it, sends a ButtonActionConfirmation to update the original message's button state, and sends a new message confirming the deletion. This also works correctly if the reminder has already been deleted by another action.
• Cron Handling Fixes:
  • Modified CronInterpreter to generate Quartz-compatible cron strings (e.g., ? * * for "every day").
  • Updated the cronToText logic to correctly parse and display daily recurring reminders.
• Transactional Reminder Creation: Refactored CommandHandler.handleNewReminder to first validate all inputs and generate the confirmation message. The reminder is now saved to the database only if all preceding steps succeed. This prevents inconsistent states and resolves the duplicate key error.
• Code Quality Improvements:
  • Replaced try-catch blocks for control flow with explicit checks (e.g., using a regex for UUID validation) to resolve SwallowedException warnings.
  • Removed exception swallowing in Reminder.kt to ensure cron parsing errors propagate correctly.
  • Replaced for loops with repeat where the index was unused.
• Unit Tests: Updated and corrected unit tests for CronInterpreter to align with the new, valid cron formats.
• Dependency Updates: Updated Gradle, Quarkus, Wire SDK, and other dependencies to their latest versions to ensure compatibility and security.

Dependencies (Optional)

• No new dependencies were added.

Testing

Test Coverage (Optional)

• I have added automated test to this contribution

How to Test

1. Create a recurring reminder:

   /remind to "Daily Standup" "every day at 10:00"
   

   • Verify that a confirmation message is received with the correct next 5 schedules.
2. List reminders:

   /remind list
   

   • Verify that the new reminder is listed with the text 'Daily Standup' at: every day at 10:00.
   • Verify that a "Delete" button is present.
3. Delete reminder via button:
   • Click the "Delete" button on the message from the list command.
   • Verify that the button is updated/disabled.
   • Verify that a new message is received confirming the deletion (e.g., "The reminder 'Daily Standup' was deleted.").
4. Attempt to delete again:
   • Click the "Delete" button on creation confirmation message.
   • Verify the button is updated and a message is received indicating the reminder was not found.

PR Post Submission Checklist for internal contributors (Optional)

• Wire's Github Workflow has automatically linked the PR to a JIRA issue

---

References

1. https://sparkbox.com/foundry/semantic_commit_messages
2. https://github.com/wireapp/.github#usage
3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

[bbaarriiss]

LGTM thanks @olanokhin . But I would like you to wait also for @yamilmedina 's review.

[yamilmedina]

lgtm 🚀