Skip to content

fix: flaky CommitPendingProposalsGeneratorTests - WPB-23898#4403

Merged
netbe merged 2 commits intodevelopfrom
fix/hang-tests
Mar 6, 2026
Merged

fix: flaky CommitPendingProposalsGeneratorTests - WPB-23898#4403
netbe merged 2 commits intodevelopfrom
fix/hang-tests

Conversation

@netbe
Copy link
Collaborator

@netbe netbe commented Mar 6, 2026

BugWPB-23898 [iOS] [CI] Flaky tests on CommitPendingProposalsGeneratorTests

Issue

Sometimes CommitPendingProposalsGeneratorTests are flaky or even hangs forever on CI.

  • rewrite test so it does not rely on time
  • add time limit so if test fails it does not hang

Testing

  • run multiple times

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@netbe netbe requested review from a team, David-Henner and jullianm and removed request for a team March 6, 2026 08:01
@netbe netbe enabled auto-merge March 6, 2026 08:01
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 6, 2026

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2026

Test Results

  1 files  132 suites   16s ⏱️
495 tests 495 ✅ 0 💤 0 ❌
496 runs  496 ✅ 0 💤 0 ❌

Results for commit 4442a31.

Summary: workflow run #22754687002
Allure report (download zip): html-report-28330-fix_hang-tests

Copy link
Contributor

@jullianm jullianm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@netbe netbe added this pull request to the merge queue Mar 6, 2026
Merged via the queue into develop with commit 6e082a3 Mar 6, 2026
11 checks passed
@netbe netbe deleted the fix/hang-tests branch March 6, 2026 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants