feat: support editing meetings - WPB-25501 by caldrian · Pull Request #5043 · wireapp/wire-ios

caldrian · 2026-07-22T10:36:14Z

WPB-25501 [iOS] Edit a meeting

Issue

This PR adds support for editing existing meetings.

Testing

Enable the WireMeetings feature flag.
Create a meeting.
Edit the meeting from the list of meetings, try to change the participants, time, title and/or recurrence.

Checklist

Title contains a reference JIRA issue number like [WPB-XXX].
Description is filled and free of optional paragraphs.
Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

Make sure you use the API for UI elements that support large fonts.
All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
New UI elements have Accessibility strings for VoiceOver.

…meeting-WPB-25501

Copilot

Pull request overview

This PR adds end-to-end support for editing existing meetings, spanning the network layer (update request encoding), domain layer (update use case + repositories), and WireCalling UI (edit-mode meeting form + member selection), with accompanying unit/snapshot test updates.

Changes:

Add an UpdateMeetingUseCase and repository support to update meetings and adjust conversation participants.
Extend the meetings UI to present a unified MeetingFormView in create/schedule/edit modes, plus a new member selection screen.
Update WireNetwork meeting update request encoding/snapshots (including explicit recurrence: null) and expand tests/snapshot reference assets.

Reviewed changes

Copilot reviewed 38 out of 69 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
WireNetwork/Tests/WireNetworkTests/APIs/Rest/MeetingsAPI/Snapshots/MeetingsAPITests/testUpdateMeeting_Request_Generation_V16.request-0-v16.txt	Snapshot updated to include `recurrence:null` in update request body
WireNetwork/Sources/WireNetwork/Models/Meetings/UpdateMeetingParameters.swift	Update-meeting encoding adjusted (explicit `null` recurrence)
WireDomain/Tests/WireDomainTests/Synchronization/PullMeetingsSyncTests.swift	Test mock expanded to include `updateMeeting` and richer `deleteMeeting` tracking
WireCalling/Tests/WireCallingTests/WireMeetings/PresentationTests/Views/ScheduledMeetingFormViewSnapshotTests.swift	Snapshot tests migrated to `MeetingFormView` / `MeetingFormViewModel`
WireCalling/Tests/WireCallingTests/WireMeetings/PresentationTests/Views/InstantMeetingFormViewSnapshotTests.swift	Snapshot tests migrated to `MeetingFormView` / `MeetingFormViewModel`
WireCalling/Tests/WireCallingTests/WireMeetings/PresentationTests/Views/EditMeetingFormViewSnapshotTests.swift	New snapshot coverage for edit-mode form rendering
WireCalling/Tests/WireCallingTests/WireMeetings/PresentationTests/MeetingFormViewModelTests.swift	Tests migrated/expanded for edit mode and update-submit behavior
WireCalling/Tests/WireCallingTests/WireMeetings/DomainTests/UpdateMeetingUseCaseTests.swift	New unit tests for update use case participant diffing + failure behavior
WireCalling/Tests/WireCallingTests/Resources/ReferenceImages/ScheduledMeetingFormViewSnapshotTests/testEmptyStateDynamicTypeVariants.xxxLarge.png	Snapshot reference image (Git LFS)
WireCalling/Tests/WireCallingTests/Resources/ReferenceImages/ScheduledMeetingFormViewSnapshotTests/testEmptyStateDynamicTypeVariants.xxLarge.png	Snapshot reference image (Git LFS)
WireCalling/Tests/WireCallingTests/Resources/ReferenceImages/ScheduledMeetingFormViewSnapshotTests/testEmptyStateDynamicTypeVariants.xSmall.png	Snapshot reference image (Git LFS)
WireCalling/Tests/WireCallingTests/Resources/ReferenceImages/ScheduledMeetingFormViewSnapshotTests/testEmptyStateDynamicTypeVariants.xLarge.png	Snapshot reference image (Git LFS)
WireCalling/Tests/WireCallingTests/Resources/ReferenceImages/ScheduledMeetingFormViewSnapshotTests/testEmptyStateDynamicTypeVariants.small.png	Snapshot reference image (Git LFS)
WireCalling/Tests/WireCallingTests/Resources/ReferenceImages/ScheduledMeetingFormViewSnapshotTests/testEmptyStateDynamicTypeVariants.medium.png	Snapshot reference image (Git LFS)
WireCalling/Tests/WireCallingTests/Resources/ReferenceImages/ScheduledMeetingFormViewSnapshotTests/testEmptyStateDynamicTypeVariants.large.png	Snapshot reference image (Git LFS)
WireCalling/Tests/WireCallingTests/Resources/ReferenceImages/ScheduledMeetingFormViewSnapshotTests/testEmptyStateDynamicTypeVariants.accessibility5.png	Snapshot reference image (Git LFS)
WireCalling/Tests/WireCallingTests/Resources/ReferenceImages/ScheduledMeetingFormViewSnapshotTests/testEmptyStateDynamicTypeVariants.accessibility4.png	Snapshot reference image (Git LFS)
WireCalling/Tests/WireCallingTests/Resources/ReferenceImages/ScheduledMeetingFormViewSnapshotTests/testEmptyStateDynamicTypeVariants.accessibility3.png	Snapshot reference image (Git LFS)
WireCalling/Tests/WireCallingTests/Resources/ReferenceImages/ScheduledMeetingFormViewSnapshotTests/testEmptyStateDynamicTypeVariants.accessibility2.png	Snapshot reference image (Git LFS)
WireCalling/Tests/WireCallingTests/Resources/ReferenceImages/ScheduledMeetingFormViewSnapshotTests/testEmptyStateDynamicTypeVariants.accessibility1.png	Snapshot reference image (Git LFS)
WireCalling/Tests/WireCallingTests/Resources/ReferenceImages/ScheduledMeetingFormViewSnapshotTests/testEmptyStateColorSchemeVariants.light.png	Snapshot reference image (Git LFS)
WireCalling/Tests/WireCallingTests/Resources/ReferenceImages/ScheduledMeetingFormViewSnapshotTests/testEmptyStateColorSchemeVariants.dark.png	Snapshot reference image (Git LFS)
WireCalling/Tests/WireCallingTests/Resources/ReferenceImages/InstantMeetingFormViewSnapshotTests/testEmptyStateDynamicTypeVariants.xxxLarge.png	Snapshot reference image (Git LFS)
WireCalling/Tests/WireCallingTests/Resources/ReferenceImages/InstantMeetingFormViewSnapshotTests/testEmptyStateDynamicTypeVariants.xxLarge.png	Snapshot reference image (Git LFS)
WireCalling/Tests/WireCallingTests/Resources/ReferenceImages/InstantMeetingFormViewSnapshotTests/testEmptyStateDynamicTypeVariants.xSmall.png	Snapshot reference image (Git LFS)
WireCalling/Tests/WireCallingTests/Resources/ReferenceImages/InstantMeetingFormViewSnapshotTests/testEmptyStateDynamicTypeVariants.xLarge.png	Snapshot reference image (Git LFS)
WireCalling/Tests/WireCallingTests/Resources/ReferenceImages/InstantMeetingFormViewSnapshotTests/testEmptyStateDynamicTypeVariants.small.png	Snapshot reference image (Git LFS)
WireCalling/Tests/WireCallingTests/Resources/ReferenceImages/InstantMeetingFormViewSnapshotTests/testEmptyStateDynamicTypeVariants.medium.png	Snapshot reference image (Git LFS)
WireCalling/Tests/WireCallingTests/Resources/ReferenceImages/InstantMeetingFormViewSnapshotTests/testEmptyStateDynamicTypeVariants.large.png	Snapshot reference image (Git LFS)
WireCalling/Tests/WireCallingTests/Resources/ReferenceImages/InstantMeetingFormViewSnapshotTests/testEmptyStateDynamicTypeVariants.accessibility5.png	Snapshot reference image (Git LFS)
WireCalling/Tests/WireCallingTests/Resources/ReferenceImages/InstantMeetingFormViewSnapshotTests/testEmptyStateDynamicTypeVariants.accessibility4.png	Snapshot reference image (Git LFS)
WireCalling/Tests/WireCallingTests/Resources/ReferenceImages/InstantMeetingFormViewSnapshotTests/testEmptyStateDynamicTypeVariants.accessibility3.png	Snapshot reference image (Git LFS)
WireCalling/Tests/WireCallingTests/Resources/ReferenceImages/InstantMeetingFormViewSnapshotTests/testEmptyStateDynamicTypeVariants.accessibility2.png	Snapshot reference image (Git LFS)
WireCalling/Tests/WireCallingTests/Resources/ReferenceImages/InstantMeetingFormViewSnapshotTests/testEmptyStateDynamicTypeVariants.accessibility1.png	Snapshot reference image (Git LFS)
WireCalling/Tests/WireCallingTests/Resources/ReferenceImages/InstantMeetingFormViewSnapshotTests/testEmptyStateColorSchemeVariants.light.png	Snapshot reference image (Git LFS)
WireCalling/Tests/WireCallingTests/Resources/ReferenceImages/InstantMeetingFormViewSnapshotTests/testEmptyStateColorSchemeVariants.dark.png	Snapshot reference image (Git LFS)
WireCalling/Tests/WireCallingTests/Resources/ReferenceImages/EditMeetingFormViewSnapshotTests/testPrefilledFormDynamicTypeVariants.xxxLarge.png	Snapshot reference image pointer added (Git LFS)
WireCalling/Tests/WireCallingTests/Resources/ReferenceImages/EditMeetingFormViewSnapshotTests/testPrefilledFormDynamicTypeVariants.xxLarge.png	Snapshot reference image pointer added (Git LFS)
WireCalling/Tests/WireCallingTests/Resources/ReferenceImages/EditMeetingFormViewSnapshotTests/testPrefilledFormDynamicTypeVariants.xSmall.png	Snapshot reference image pointer added (Git LFS)
WireCalling/Tests/WireCallingTests/Resources/ReferenceImages/EditMeetingFormViewSnapshotTests/testPrefilledFormDynamicTypeVariants.xLarge.png	Snapshot reference image pointer added (Git LFS)
WireCalling/Tests/WireCallingTests/Resources/ReferenceImages/EditMeetingFormViewSnapshotTests/testPrefilledFormDynamicTypeVariants.small.png	Snapshot reference image pointer added (Git LFS)
WireCalling/Tests/WireCallingTests/Resources/ReferenceImages/EditMeetingFormViewSnapshotTests/testPrefilledFormDynamicTypeVariants.medium.png	Snapshot reference image pointer added (Git LFS)
WireCalling/Tests/WireCallingTests/Resources/ReferenceImages/EditMeetingFormViewSnapshotTests/testPrefilledFormDynamicTypeVariants.large.png	Snapshot reference image pointer added (Git LFS)
WireCalling/Tests/WireCallingTests/Resources/ReferenceImages/EditMeetingFormViewSnapshotTests/testPrefilledFormDynamicTypeVariants.accessibility5.png	Snapshot reference image pointer added (Git LFS)
WireCalling/Tests/WireCallingTests/Resources/ReferenceImages/EditMeetingFormViewSnapshotTests/testPrefilledFormDynamicTypeVariants.accessibility4.png	Snapshot reference image pointer added (Git LFS)
WireCalling/Tests/WireCallingTests/Resources/ReferenceImages/EditMeetingFormViewSnapshotTests/testPrefilledFormDynamicTypeVariants.accessibility3.png	Snapshot reference image pointer added (Git LFS)
WireCalling/Tests/WireCallingTests/Resources/ReferenceImages/EditMeetingFormViewSnapshotTests/testPrefilledFormDynamicTypeVariants.accessibility2.png	Snapshot reference image pointer added (Git LFS)
WireCalling/Tests/WireCallingTests/Resources/ReferenceImages/EditMeetingFormViewSnapshotTests/testPrefilledFormDynamicTypeVariants.accessibility1.png	Snapshot reference image pointer added (Git LFS)
WireCalling/Tests/WireCallingTests/Resources/ReferenceImages/EditMeetingFormViewSnapshotTests/testPrefilledFormColorSchemeVariants.light.png	Snapshot reference image pointer added (Git LFS)
WireCalling/Tests/WireCallingTests/Resources/ReferenceImages/EditMeetingFormViewSnapshotTests/testPrefilledFormColorSchemeVariants.dark.png	Snapshot reference image pointer added (Git LFS)
WireCalling/Sources/WireCallingUI/Views/WireMeetings/MeetingsView/MeetingsView.swift	Plumb edit action via `onEditMeeting` callback
WireCalling/Sources/WireCallingUI/Views/WireMeetings/MeetingsView/AllMeetingsViewModel.swift	Present edit-mode form by setting `.edit(meeting)`
WireCalling/Sources/WireCallingUI/Views/WireMeetings/MeetingsView/AllMeetingsView.swift	Wire edit action from list into the form sheet presentation
WireCalling/Sources/WireCallingUI/Views/WireMeetings/MeetingForm/MemberSelection/MemberSelectionViewModel.swift	New view model for debounced member search + selection state
WireCalling/Sources/WireCallingUI/Views/WireMeetings/MeetingForm/MemberSelection/MemberSelectionView.swift	New SwiftUI member selection screen (search + selected list)
WireCalling/Sources/WireCallingUI/Views/WireMeetings/MeetingForm/MeetingRepeatOption.swift	New repeat-option enum used by the meeting form
WireCalling/Sources/WireCallingUI/Views/WireMeetings/MeetingForm/MeetingFormViewModel.swift	Rename/extend form view model to support edit mode + update use case
WireCalling/Sources/WireCallingUI/Views/WireMeetings/MeetingForm/MeetingFormView.swift	Rename/extend form view to support edit mode (labels, focus behavior, previews)
WireCalling/Sources/WireCallingUI/Resources/Localization/en.lproj/Localizable.strings	Add “Edit meeting” + “Save” strings
WireCalling/Sources/WireCallingDomain/WireMeetings/UseCases/UpdateMeetingUseCase.swift	New use case to update meeting + sync participants with conversation
WireCalling/Sources/WireCallingDomain/WireMeetings/Protocols/UpdateMeetingUseCaseProtocol.swift	New protocol for update use case
WireCalling/Sources/WireCallingDomain/WireMeetings/Protocols/MeetingRepositoryProtocol.swift	Add `updateMeeting` API to repository
WireCalling/Sources/WireCallingDomain/WireMeetings/Protocols/MeetingConversationRepositoryProtocol.swift	Add `removeParticipants` API
WireCalling/Sources/WireCallingDomain/WireMeetings/Model/MeetingRecurrence.swift	Make recurrence `Hashable` (needed for edit mode identity)
WireCalling/Sources/WireCallingDomain/WireMeetings/Model/Meeting.swift	Make meeting `Hashable` (needed for edit mode identity)
WireCalling/Sources/WireCallingData/MeetingRepository.swift	Implement `updateMeeting` via WireNetwork and refresh local store
WireCalling/Sources/WireCallingAssembly/WireMeetingsFactory.swift	Wire `UpdateMeetingUseCase` into the UI view-model factory
wire-ios/Wire-iOS/Sources/UserInterface/MainController/ZClientViewController.swift	Provide participants service dependency for meeting conversation bridge
wire-ios/Wire-iOS/Sources/UserInterface/Calling/Meetings/MeetingConversationRepositoryBridge.swift	Support participant removal + established-group add-members path

Comments suppressed due to low confidence (1)

WireCalling/Sources/WireCallingUI/Views/WireMeetings/MeetingForm/MeetingFormViewModel.swift:249

In edit mode, unsupported recurrence intervals are collapsed to a supported MeetingRepeatOption (e.g. weekly interval 3 -> .weekly). If the user edits something unrelated (like the title) and taps Save, toRecurrence() will write back the collapsed value, silently changing the meeting’s recurrence. Consider preserving the original meeting.recurrence unless the user explicitly changes the repeat option, or representing unsupported recurrences explicitly in the UI.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

github-actions · 2026-07-22T12:03:03Z

Test Results – batch 1

2 340 tests 2 313 ✅ 2m 31s ⏱️
343 suites 27 💤
2 files 0 ❌

Results for commit f8fac5a.

♻️ This comment has been updated with latest results.

github-actions · 2026-07-22T12:03:23Z

Test Results – batch 0

2 files 160 suites 25s ⏱️
686 tests 686 ✅ 0 💤 0 ❌
687 runs 687 ✅ 0 💤 0 ❌

Results for commit f8fac5a.

♻️ This comment has been updated with latest results.

datadog-wireapp · 2026-07-22T12:04:29Z

⚠️ Warnings

🧪 2 Tests failed

testPrefilledFormColorSchemeVariants() from WireCallingTests.EditMeetingFormViewSnapshotTests

testPrefilledFormDynamicTypeVariants() from WireCallingTests.EditMeetingFormViewSnapshotTests

Useful? React with 👍 / 👎

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: 244c56a | Docs | Give us feedback!}

…0-0c785c9486b6107f1f24b939e82c3dc7134964b3' into feat/edit-meeting-WPB-25501

…meeting-WPB-25501

Copilot

Pull request overview

Copilot reviewed 41 out of 72 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

WireCalling/Sources/WireCallingUI/Views/WireMeetings/MeetingForm/MeetingFormViewModel.swift:48

The edit-mode docstring is now out of sync with the actual UI strings: the primary button label comes from wireMeetings.schedule.save.button (currently "Confirm"), and the navigation title from wireMeetings.schedule.edit.title ("Edit Meeting"). Keeping the comment accurate avoids misleading future changes.

…g-WPB-25501 # Conflicts: # WireDomain/Sources/WireDomain/Repositories/Meetings/MeetingLocalStore.swift

jullianm

Nice work

…' into feat/edit-meeting-WPB-25501

caldrian added 8 commits July 22, 2026 11:22

repositories

1540ca9

use cases

7dea1df

UI

e15a690

edit button

6c05b62

tests

a7d9682

Merge branch 'develop' of github.com:wireapp/wire-ios into feat/edit-…

15a32d9

…meeting-WPB-25501

snapshot image placeholders

0e38c70

renamings

244c56a

github-actions Bot assigned caldrian Jul 22, 2026

caldrian added the WIP label Jul 22, 2026

caldrian marked this pull request as ready for review July 22, 2026 11:45

Copilot AI review requested due to automatic review settings July 22, 2026 11:45

Copilot started reviewing on behalf of caldrian July 22, 2026 11:45 View session

caldrian changed the title ~~feat: support editing meetings - WPB-25501~~ feat: support editing meetings - WPB-25501x Jul 22, 2026

caldrian changed the title ~~feat: support editing meetings - WPB-25501x~~ feat: support editing meetings - WPB-25501 Jul 22, 2026

Copilot AI reviewed Jul 22, 2026

View reviewed changes

caldrian added 3 commits July 22, 2026 14:05

update snapshot reference images

262d4a3

minor fix

c01ffd0

delete TODO

fb58574

caldrian marked this pull request as draft July 22, 2026 19:12

caldrian added 7 commits July 22, 2026 21:13

Merge remote-tracking branch 'github/gh-readonly-queue/develop/pr-498…

9b6e4a8

…0-0c785c9486b6107f1f24b939e82c3dc7134964b3' into feat/edit-meeting-WPB-25501

Merge branch 'develop' of github.com:wireapp/wire-ios into feat/edit-…

ba75fe5

…meeting-WPB-25501

Merge branch 'develop' of github.com:wireapp/wire-ios into feat/edit-…

8dcc51e

…meeting-WPB-25501

attempt to load meeting members

2bdaea0

different approach

a793fe3

Merge branch 'develop' of github.com:wireapp/wire-ios into feat/edit-…

4016e1b

…meeting-WPB-25501

fetch meeting after storing

a8d1c75

caldrian marked this pull request as ready for review July 23, 2026 13:04

caldrian added 6 commits July 24, 2026 09:59

Merge branch 'develop' of github.com:wireapp/wire-ios into feat/edit-…

fc3d080

…meeting-WPB-25501

Minor fixes

a1529bc

update snapshot reference images

cfb2e0b

update button title

4950c9e

format code

36ceaed

resolve comment

004895d

caldrian removed the WIP label Jul 24, 2026

caldrian requested review from a team, Copilot, johnxnguyen, jullianm and samwyndham and removed request for a team and johnxnguyen July 24, 2026 13:02

Copilot started reviewing on behalf of caldrian July 24, 2026 13:03 View session

Copilot AI reviewed Jul 24, 2026

View reviewed changes

Comment thread WireCalling/Sources/WireCallingUI/Resources/Localization/en.lproj/Localizable.strings

caldrian added 2 commits July 24, 2026 15:25

update snapshot reference images

fe036db

Merge branch 'feat/fetch-meetings-participants' into feat/edit-meetin…

d4b962f

…g-WPB-25501 # Conflicts: # WireDomain/Sources/WireDomain/Repositories/Meetings/MeetingLocalStore.swift

jullianm approved these changes Jul 24, 2026

View reviewed changes

fix conflicts

44d2290

caldrian changed the base branch from develop to feat/fetch-meetings-participants July 24, 2026 14:46

caldrian added 3 commits July 24, 2026 16:47

fix warning

60a95fe

fix build errors

127b9ef

Merge remote-tracking branch 'github/feat/fetch-meetings-participants…

f8fac5a

…' into feat/edit-meeting-WPB-25501

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: support editing meetings - WPB-25501#5043

feat: support editing meetings - WPB-25501#5043
caldrian wants to merge 30 commits into
feat/fetch-meetings-participantsfrom
feat/edit-meeting-WPB-25501

caldrian commented Jul 22, 2026 •

edited by github-actions Bot

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Jul 22, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jul 22, 2026 •

edited

Loading

Uh oh!

datadog-wireapp Bot commented Jul 22, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

jullianm left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

caldrian commented Jul 22, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue

Testing

Checklist

UI accessibility checklist

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results – batch 1

Uh oh!

github-actions Bot commented Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results – batch 0

Uh oh!

datadog-wireapp Bot commented Jul 22, 2026

⚠️ Warnings

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

jullianm left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

caldrian commented Jul 22, 2026 •

edited by github-actions Bot

Loading

github-actions Bot commented Jul 22, 2026 •

edited

Loading

github-actions Bot commented Jul 22, 2026 •

edited

Loading