Skip to content

fix: show loader when processing video from the native gallery picker - WPB-27398#5055

Open
jullianm wants to merge 1 commit into
developfrom
fix/show-loader-on-selected-video-from-native-picker
Open

fix: show loader when processing video from the native gallery picker - WPB-27398#5055
jullianm wants to merge 1 commit into
developfrom
fix/show-loader-on-selected-video-from-native-picker

Conversation

@jullianm

@jullianm jullianm commented Jul 23, 2026

Copy link
Copy Markdown
Contributor
TaskWPB-27398 [iOS] Show loader when video is being processed from native gallery picker

Issue

Fixes a missing loading indicator when a video selected from the native gallery picker is being processed for a Shared Drive conversation.

  • Extracted a showActivityIndicator(_:) helper on CameraKeyboardViewController that wraps the existing activityIndicator.start()/stop() calls in DispatchQueue.main.async, replacing the repeated inline dispatch blocks.
  • ConversationInputBarViewController+ImagePickerDriveConversation now calls cameraKeyboardViewController?.showActivityIndicator(true) when a video is picked via the native PHPickerViewController for a Wire Drive conversation, and stops it once the video finishes loading, copying, or converting (including on early-return error paths).

Testing

  • Pick a video from the native gallery picker in a Shared Drive conversation and confirm a loading indicator appears while the video is processed and disappears once the upload starts.
  • Trigger the error paths (failed load, failed copy, failed conversion) and confirm the loading indicator is dismissed in each case.

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@jullianm
jullianm requested review from a team, David-Henner and KaterinaWire and removed request for a team July 23, 2026 13:57
@github-actions

github-actions Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Test Results

1 936 tests   1 909 ✅  2m 35s ⏱️
  304 suites     27 💤
    1 files        0 ❌

Results for commit 2cf6a01.

Summary: workflow run #30013532934
Allure report (download zip): html-report-32270-fix_show-loader-on-selected-video-from-native-picker

@jullianm
jullianm requested review from caldrian and removed request for David-Henner July 24, 2026 07:29
@caldrian
caldrian requested a review from Copilot July 24, 2026 13:25

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses missing user feedback during video processing when selecting a video via the native gallery picker in a Wire Drive (Shared Drive) conversation, by ensuring a loading indicator is shown while the video is loaded/copied/converted.

Changes:

  • Show the camera keyboard activity indicator at the start of Wire Drive video processing, and reliably hide it on success and early-return error paths.
  • Refactor repeated DispatchQueue.main.async { activityIndicator.start()/stop() } blocks into a single showActivityIndicator(_:) helper on CameraKeyboardViewController.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
wire-ios/Wire-iOS/Sources/UserInterface/Conversation/InputBar/ConversationInputBarViewController+ImagePickerDriveConversation.swift Shows/hides the loader around native-picker Wire Drive video load/copy/convert steps.
wire-ios/Wire-iOS/Sources/UserInterface/Conversation/InputBar/CameraKeyboard/CameraKeyboardViewController.swift Centralizes activity-indicator toggling into showActivityIndicator(_:) and uses it in existing media flows.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants