fix: show loader when processing video from the native gallery picker - WPB-27398#5055
Open
jullianm wants to merge 1 commit into
Open
fix: show loader when processing video from the native gallery picker - WPB-27398#5055jullianm wants to merge 1 commit into
jullianm wants to merge 1 commit into
Conversation
jullianm
requested review from
a team,
David-Henner and
KaterinaWire
and removed request for
a team
July 23, 2026 13:57
Contributor
Test Results1 936 tests 1 909 ✅ 2m 35s ⏱️ Results for commit 2cf6a01. Summary: workflow run #30013532934 |
caldrian
approved these changes
Jul 24, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses missing user feedback during video processing when selecting a video via the native gallery picker in a Wire Drive (Shared Drive) conversation, by ensuring a loading indicator is shown while the video is loaded/copied/converted.
Changes:
- Show the camera keyboard activity indicator at the start of Wire Drive video processing, and reliably hide it on success and early-return error paths.
- Refactor repeated
DispatchQueue.main.async { activityIndicator.start()/stop() }blocks into a singleshowActivityIndicator(_:)helper onCameraKeyboardViewController.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| wire-ios/Wire-iOS/Sources/UserInterface/Conversation/InputBar/ConversationInputBarViewController+ImagePickerDriveConversation.swift | Shows/hides the loader around native-picker Wire Drive video load/copy/convert steps. |
| wire-ios/Wire-iOS/Sources/UserInterface/Conversation/InputBar/CameraKeyboard/CameraKeyboardViewController.swift | Centralizes activity-indicator toggling into showActivityIndicator(_:) and uses it in existing media flows. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
KaterinaWire
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Fixes a missing loading indicator when a video selected from the native gallery picker is being processed for a Shared Drive conversation.
showActivityIndicator(_:)helper onCameraKeyboardViewControllerthat wraps the existingactivityIndicator.start()/stop()calls inDispatchQueue.main.async, replacing the repeated inline dispatch blocks.ConversationInputBarViewController+ImagePickerDriveConversationnow callscameraKeyboardViewController?.showActivityIndicator(true)when a video is picked via the nativePHPickerViewControllerfor a Wire Drive conversation, and stops it once the video finishes loading, copying, or converting (including on early-return error paths).Testing
Checklist
[WPB-XXX].UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: