[WPB-11196] Generate schemas for <service>.yaml #4324
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echoes-hq
bot
added
echoes: technical-roadmap/technical-debt
fisx
changed the title
zebot
added
the
ok-to-test
fisx
force-pushed
the
WPB-11196-list-backend-config-options
branch
6 times, most recently
from
934b26b to
7978547
Compare
fisx
force-pushed
the
WPB-11196-list-backend-config-options
branch
from
dca3af9 to
49e9e18
Compare
fisx
force-pushed
the
WPB-11196-list-backend-config-options
branch
from
49e9e18 to
72f2112
Compare
MangoIV
reviewed
Nov 7, 2024
Comment on lines
+133
to
+137
| instance {-# OVERLAPPABLE #-} (ToJSON a) => MimeRender YAML a where | ||
| mimeRender _ = fromStrict . Y.encode | ||
|
|
||
| instance {-# OVERLAPPABLE #-} (FromJSON a) => MimeUnrender YAML a where | ||
| mimeUnrender _ = first show . Y.decodeEither' . toStrict |
Contributor
There was a problem hiding this comment.
Are you sure you want to make this OVERLAPPABLE? I think making every instance that would overlap OVERLAPPING is the better UX as you wouldn't want to accidentally write a new instance for a more specific type, unaware that these instances exist.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
changelog.d