Skip to content

Conversation

@florian-lefebvre
Copy link
Member

Changes

  • After discussing with @delucis, we came to the conclusion that having sans-serif as a default fallback makes sense so users can benefit from automatic fallback generation by default

Testing

N/A

Docs

Will be documented properly alongside all defaults

@florian-lefebvre florian-lefebvre self-assigned this Mar 30, 2025
@changeset-bot
Copy link

changeset-bot bot commented Mar 30, 2025

⚠️ No Changeset found

Latest commit: 596753e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Mar 30, 2025
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure to update the RFC with this information. I just checked it and it doesn't mention sans-serif being fallback.

@florian-lefebvre
Copy link
Member Author

Ah yes I forgot, I'll add it now

@florian-lefebvre florian-lefebvre merged commit d893932 into feat/fonts Mar 31, 2025
14 checks passed
@florian-lefebvre florian-lefebvre deleted the feat/fonts-default-fallbacks branch March 31, 2025 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: astro Related to the core `astro` package (scope)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants