Skip to content

feat(fonts): set default fallbacks #13516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Parent: feat(fonts): experimental release
merged 1 commit into from
Mar 31, 2025
Merged

feat(fonts): set default fallbacks #13516

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/astro/src/assets/fonts/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ export const DEFAULTS: ResolveFontOptions = {
weights: ['400'],
styles: ['normal', 'italic'],
subsets: ['cyrillic-ext', 'cyrillic', 'greek-ext', 'greek', 'vietnamese', 'latin-ext', 'latin'],
// Technically serif is the browser default but most websites these days use sans-serif
fallbacks: ['sans-serif'],
automaticFallback: true,
};

Expand Down
3 changes: 1 addition & 2 deletions packages/astro/src/assets/fonts/load.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,8 +117,7 @@ export async function loadFonts({
weights: family.weights ?? DEFAULTS.weights,
styles: family.styles ?? DEFAULTS.styles,
subsets: family.subsets ?? DEFAULTS.subsets,
// No default fallback to be used here
fallbacks: family.fallbacks,
fallbacks: family.fallbacks ?? DEFAULTS.fallbacks,
},
// By default, unifont goes through all providers. We use a different approach
// where we specify a provider per font (default to google)
Expand Down