Skip to content

feat(next): envField jsdoc #11927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 6, 2024
Merged

feat(next): envField jsdoc #11927

merged 4 commits into from
Sep 6, 2024

Conversation

florian-lefebvre
Copy link
Member

Changes

  • What does this change?
  • Be short and concise. Bullet points can help!
  • Before/after screenshots can help as well.
  • Don't forget a changeset! pnpm exec changeset

Testing

Docs

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 5, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: c9a8628

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) docs pr labels Sep 5, 2024
sarah11918
sarah11918 reviewed Sep 5, 2024
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than this needing to be its own separate entry (so a full set of jsdoc headers) this looks great! I also gave an example intro to the entry.

sarah11918
sarah11918 reviewed Sep 5, 2024
View reviewed changes
sarah11918
sarah11918 reviewed Sep 5, 2024
View reviewed changes
sarah11918
sarah11918 approved these changes Sep 5, 2024
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what we needed, thanks @florian-lefebvre

@florian-lefebvre florian-lefebvre merged commit 5b4e3ab into next Sep 6, 2024
12 of 14 checks passed
@florian-lefebvre florian-lefebvre deleted the feat/next-env-field-jsdoc branch September 6, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sarah11918 sarah11918 sarah11918 approved these changes

Assignees

No one assigned

Labels

docs pr pkg: astro Related to the core `astro` package (scope)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@florian-lefebvre @sarah11918