Add server island route to the front of the route list

[Fryuni]

Changes

• Fixes Catch all page ([...slug].astro) catch all Server island requests #11793

The route was being added as the last route in the list, making it the lowest priority. The solution would be to either add it before the routes are sorted by priority or make it higher than other routes.

IMO internal routes should come first since they are required for native Astro features to work, so adding it to the front of the list is enough. If we think they should follow the normal route priority then the fix is different (insert the route based on the priority rules).

Testing

Added a conflicting route on the e2e test fixture to reproduce the problem.

Docs

Maybe document the prefixes reserved for Astro functionality (_server-islands/, _actions/ and _astro/)

[changeset-bot]

🦋 Changeset detected

Latest commit: 394e5e1

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[martrapp]

Looks good to me!

[ematipico]

Looks good to me. If possible, I would send a PR to the docs as you suggested. I think it's important to set expectations for the users (and us).

[matthewp]

beat me to it, thanks so much!