Skip to content

Conversation

@ematipico
Copy link
Member

Changes

This PR is follow-up of withastro/adapters#424

Testing

CI should pass

Docs

N/A

@changeset-bot
Copy link

changeset-bot bot commented Oct 21, 2024

🦋 Changeset detected

Latest commit: 19db547

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) semver: major Change triggers a `major` release labels Oct 21, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is blocked because it contains a major changeset. A reviewer will merge this at the next release if approved.

@florian-lefebvre
Copy link
Member

Actually, what happens if someone adds the vercel adapter and specify a specific version <= 8.0?

@Princesseuh
Copy link
Member

Actually, what happens if someone adds the vercel adapter and specify a specific version <= 8.0?

it wouldn't work, but this is on next, so anyway installing an old version would result in a broken build

@ematipico ematipico merged commit 4e9a3ac into next Oct 25, 2024
2 checks passed
@ematipico ematipico deleted the feat/update-vercel-entrypoint branch October 25, 2024 13:17
@phenomen
Copy link

I changed import in astro.config.mjs from @astrojs/vercel/serverless to @astrojs/vercel and now I get this error on build:

[AdapterSupportOutputMismatch] The @astrojs/vercel adapter is configured to output a static website, but the project contains server-rendered pages. Please install and configure the appropriate server adapter for your final deployment.

"@astrojs/vercel": "8.0.0-beta.3",
"astro": "5.0.0-beta.6",

@ematipico
Copy link
Member Author

@phenomen please open an issue, create a reproduction so we can look after your issue. Please don't comment on closed issues/PRs because they don't get enough visibility

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: astro Related to the core `astro` package (scope) semver: major Change triggers a `major` release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants