Skip to content

Conversation

@Jacob-Roberts
Copy link

@Jacob-Roberts Jacob-Roberts commented Oct 25, 2024

See proposal withastro/roadmap#1043 to see the full reasoning behind this change.

My ultimate goal is to make this an integration, but as it stands, I haven't been able to make it work fully as a plugin without changing the core. So I'm very open to feedback.

Changes

  • Allow changing the domain that the server islands are hosted on.
  • Allow developers to split the "static" part and the "dynamic" part of their website fully.
  • Allows developers that cannot give Cloudflare the ability to read their customer's data to still use Astro's great site builder.
  • Use a specific integration so we don't pollute the main astro config.

With config:
Screenshot 2024-10-28 at 9 02 01 PM

Result:
Screenshot 2024-10-25 at 11 00 17 PM

Testing

Currently just a manual test has been run. No automated tests have been added.

TODO: Add automated tests.

Docs

TODO: Doc updates

@changeset-bot
Copy link

changeset-bot bot commented Oct 25, 2024

⚠️ No Changeset found

Latest commit: 72d432f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added pkg: example Related to an example package (scope) pkg: astro Related to the core `astro` package (scope) docs pr labels Oct 25, 2024
@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Oct 28, 2024
@Jacob-Roberts
Copy link
Author

Closing because this has examples/integrations that won't make it into the real repository. They will go in a separate repo and be published on their own.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs pr pkg: astro Related to the core `astro` package (scope) pkg: example Related to an example package (scope) pkg: integration Related to any renderer integration (scope)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant