Skip to content

Fixes attribute rendering for popover #13037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 28, 2025
+19 −0
Merged

Fixes attribute rendering for popover #13037

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
193d1cc
fix: Fixes attribute rendering for `popover` (#issuecomment-2605735407)
nanarino Jan 21, 2025
5260983
fix: Popover seems to be boolean, but it can actually have the value …
nanarino Jan 21, 2025
25cab0f
Merge branch 'withastro:main' into main
nanarino May 27, 2025
7a741f8
Update cool-walls-burn.md
florian-lefebvre May 28, 2025
db8f26f
Update packages/astro/src/runtime/server/render/util.ts
florian-lefebvre May 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/cool-walls-burn.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'astro': major
---

Fixes attribute rendering for `popover`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
---
'astro': major
---
Fixes attribute rendering for `popover`
---
'astro': patch
---
Fixes attribute rendering for `popover`

2 changes: 1 addition & 1 deletion packages/astro/src/runtime/server/render/util.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { HTMLString, markHTMLString } from '../escape.js';
export const voidElementNames =
/^(area|base|br|col|command|embed|hr|img|input|keygen|link|meta|param|source|track|wbr)$/i;
const htmlBooleanAttributes =
/^(?:allowfullscreen|async|autofocus|autoplay|checked|controls|default|defer|disabled|disablepictureinpicture|disableremoteplayback|formnovalidate|hidden|inert|loop|nomodule|novalidate|open|playsinline|readonly|required|reversed|scoped|seamless|selected|itemscope)$/i;
/^(?:allowfullscreen|async|autofocus|autoplay|checked|controls|default|defer|disabled|disablepictureinpicture|disableremoteplayback|formnovalidate|hidden|inert|loop|nomodule|novalidate|open|playsinline|popover|readonly|required|reversed|scoped|seamless|selected|itemscope)$/i;

const AMPERSAND_REGEX = /&/g;
const DOUBLE_QUOTE_REGEX = /"/g;
Expand Down
1 change: 1 addition & 0 deletions packages/astro/test/astro-attrs.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ describe('Attributes', async () => {
const $ = cheerio.load(html);

const attrs = {
'popover-true': { attribute: 'popover', value: '' },
'boolean-attr-true': { attribute: 'allowfullscreen', value: '' },
'boolean-attr-false': { attribute: 'allowfullscreen', value: undefined },
'boolean-attr-string-truthy': { attribute: 'allowfullscreen', value: '' },
Expand Down
2 changes: 2 additions & 0 deletions packages/astro/test/fixtures/astro-attrs/src/pages/index.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
<dialog id="popover-true" popover={true} />

<span id="boolean-attr-true" allowfullscreen={true} />
<span id="boolean-attr-false" allowfullscreen={false} />
<span id="boolean-attr-string-truthy" allowfullscreen={'foo'} />
Expand Down
Loading