Skip to content

feat(fonts): as prop #13366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: feat(fonts): experimental release
merged 2 commits into from
Mar 10, 2025
Merged

feat(fonts): as prop #13366

merged 2 commits into from
Mar 10, 2025

Conversation

@florian-lefebvre
Copy link
Member

@florian-lefebvre florian-lefebvre commented Mar 5, 2025 •
edited
Loading

Changes

  • This adds an optional as property to a font family
  • The RFC has been updated but TLDR use as if:
    1. You are an integration and want to make sure you don't conflict with fonts declared by the user
    2. Your font name can't be properly converted to a CSS variable name

Testing

Tests updated

Docs

RFC updated

@florian-lefebvre florian-lefebvre self-assigned this Mar 5, 2025
@changeset-bot
Copy link

changeset-bot bot commented Mar 5, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: cfd493e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Mar 5, 2025
@florian-lefebvre florian-lefebvre marked this pull request as ready for review March 5, 2025 15:08
ascorbic
ascorbic reviewed Mar 7, 2025
View reviewed changes
ematipico
ematipico reviewed Mar 10, 2025
View reviewed changes
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The RFC and this PR are a bit in conflict. Also, I have some important questions

@florian-lefebvre florian-lefebvre merged commit 0f3419c into feat/fonts Mar 10, 2025
4 checks passed
@florian-lefebvre florian-lefebvre deleted the feat/fonts-as-prop branch March 10, 2025 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ascorbic ascorbic ascorbic approved these changes

@ematipico ematipico ematipico approved these changes

Assignees

@florian-lefebvre florian-lefebvre

Labels

pkg: astro Related to the core `astro` package (scope)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@florian-lefebvre @ascorbic @ematipico