Skip to content

Conversation

@Haberkamp
Copy link
Contributor

Changes

The problem was the the content of the toolbar settings overflowed the toolbar. That made it very hard to read the text it looked broken.

I did a few things:

  1. The text of the last row takes up the whole width of the section
  2. If the content is still too large, the developer can scroll the content of the toolbar

Before

Bildschirmfoto 2025-03-09 um 12 37 03

After

Bildschirmaufnahme.2025-03-09.um.12.35.04.mov

Testing

I did some manual testing, by resizing the window and testing the changes on a real iPhone. I did not any automated tests, because there's now way to test this without a visual test. Please correct me if I'm wrong.

Docs

This change does not need documentation, it doesn't change how users
need to interact with Astro.

@changeset-bot
Copy link

changeset-bot bot commented Mar 9, 2025

🦋 Changeset detected

Latest commit: 88bd907

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Mar 9, 2025
@Haberkamp Haberkamp force-pushed the stop-toolbar-settings-from-overflowing branch from 667dcaa to 88bd907 Compare March 9, 2025 11:40
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 9, 2025

CodSpeed Performance Report

Merging #13383 will not alter performance

Comparing Haberkamp:stop-toolbar-settings-from-overflowing (88bd907) with main (d83f92a)

Summary

✅ 6 untouched benchmarks

@ematipico ematipico added the pr preview Apply this label to a PR to generate a preview release label Apr 16, 2025
@pkg-pr-new
Copy link

pkg-pr-new bot commented Apr 16, 2025

astro

npm i https://pkg.pr.new/astro@13383

@astrojs/cloudflare

npm i https://pkg.pr.new/@astrojs/cloudflare@13383

@astrojs/netlify

npm i https://pkg.pr.new/@astrojs/netlify@13383

@astrojs/node

npm i https://pkg.pr.new/@astrojs/node@13383

@astrojs/vercel

npm i https://pkg.pr.new/@astrojs/vercel@13383

commit: 88bd907

Copy link
Contributor

@ascorbic ascorbic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ascorbic ascorbic merged commit f7f712c into withastro:main May 21, 2025
18 checks passed
@astrobot-houston astrobot-houston mentioned this pull request May 21, 2025
openscript pushed a commit to openscript/astro that referenced this pull request Sep 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: astro Related to the core `astro` package (scope) pr preview Apply this label to a PR to generate a preview release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants