Skip to content

feat(fonts): family name validation #13417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: feat(fonts): experimental release
merged 1 commit into from
Mar 13, 2025
Merged

feat(fonts): family name validation #13417

merged 1 commit into from
Mar 13, 2025

Conversation

@florian-lefebvre
Copy link
Member

Changes

  • Validates the name of the font family, to make sure we can generate a proper css variable name

Testing

Added

Docs

N/A

@florian-lefebvre florian-lefebvre self-assigned this Mar 13, 2025
@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Mar 13, 2025
ematipico
ematipico approved these changes Mar 13, 2025
View reviewed changes
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great DX improvement 💪

@florian-lefebvre florian-lefebvre merged commit f01739d into feat/fonts Mar 13, 2025
14 checks passed
@florian-lefebvre florian-lefebvre deleted the feat/fonts-name-validation branch March 13, 2025 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ematipico ematipico ematipico approved these changes

Assignees

@florian-lefebvre florian-lefebvre

Labels

pkg: astro Related to the core `astro` package (scope)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@florian-lefebvre @ematipico