Skip to content

Conversation

@ematipico
Copy link
Member

Reverts #13347

Closes #13416

Unfortunately that PR created some unwanted regressions, and I am afraid we need to revert it

@changeset-bot
Copy link

changeset-bot bot commented Mar 13, 2025

🦋 Changeset detected

Latest commit: a94a72a

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: integration Related to any renderer integration (scope) pkg: astro Related to the core `astro` package (scope) labels Mar 13, 2025
@ematipico ematipico marked this pull request as ready for review March 13, 2025 14:56
@ematipico ematipico added the pr preview Apply this label to a PR to generate a preview release label Mar 13, 2025
@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 13, 2025

astro

npm i https://pkg.pr.new/astro@13420

@astrojs/cloudflare

npm i https://pkg.pr.new/@astrojs/cloudflare@13420

@astrojs/netlify

npm i https://pkg.pr.new/@astrojs/netlify@13420

@astrojs/node

npm i https://pkg.pr.new/@astrojs/node@13420

@astrojs/vercel

npm i https://pkg.pr.new/@astrojs/vercel@13420

commit: 13bf25e

@codspeed-hq
Copy link

codspeed-hq bot commented Mar 13, 2025

CodSpeed Performance Report

Merging #13420 will not alter performance

Comparing revert-13347-vite-css-scope-to (a94a72a) with main (be866a1)

Summary

✅ 6 untouched benchmarks

@ematipico ematipico merged commit 2f039b9 into main Mar 13, 2025
2 checks passed
@ematipico ematipico deleted the revert-13347-vite-css-scope-to branch March 13, 2025 15:19
@astrobot-houston astrobot-houston mentioned this pull request Mar 13, 2025
HPCesia added a commit to HPCesia/astral-halo that referenced this pull request Apr 5, 2025
- Remove Twikoo's local style.
- Remove local package of Artalk and Waline to minify styles

This commit is because of unused comment styles in build packaged css.

vitejs/vite#19418 might have helped, but Astro didn't use this experimental feature (withastro/astro#13420).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope) pr preview Apply this label to a PR to generate a preview release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Styling discrepancies between astro dev and astro build in 5.4.3

2 participants