fix(fonts): vite plugin cleanup #13424
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
github-actions
bot
added
the
pkg: astro
ascorbic
approved these changes
Mar 14, 2025
| if (sync) { | ||
| hashToUrlMap = null; | ||
| storage = null; | ||
| if (sync || settings.config.experimental.fonts!.families.length === 0) { |
There was a problem hiding this comment.
Just confirming that we can be sure font is always defined. Non-null assertions always make me nervous.
There was a problem hiding this comment.
Yes we're sure at this point, because we vite plugin is only created if fonts is defined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Testing
N/A
Docs
N/A