Skip to content

Conversation

@ematipico
Copy link
Member

@ematipico ematipico commented Mar 14, 2025

Changes

Refactors the types of ActionAPIContext to not inherit functions from APIContext.

Testing

CI should stay green

Docs

N/A

@changeset-bot
Copy link

changeset-bot bot commented Mar 14, 2025

🦋 Changeset detected

Latest commit: 5518924

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) docs pr labels Mar 14, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 14, 2025

CodSpeed Performance Report

Merging #13429 will not alter performance

Comparing fix/actions-context (5518924) with main (3488324)

Summary

✅ 6 untouched benchmarks

@ematipico ematipico marked this pull request as ready for review March 19, 2025 13:40
@ematipico ematipico changed the title wip fix(actions): avoid mutation of action context Mar 19, 2025
@ematipico ematipico changed the title fix(actions): avoid mutation of action context refactor(actions): use Omit to avoid leaking types to shared context Mar 24, 2025
@ematipico ematipico force-pushed the fix/actions-context branch from e1f1604 to a87df1c Compare March 24, 2025 11:42
Copy link
Member

@florian-lefebvre florian-lefebvre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a changeset? Maybe it should be a minor since there's a deprecation

@ematipico
Copy link
Member Author

Can't we ship a deprecation via patch? We don't change any APIs

@ematipico ematipico merged commit 06de673 into main Mar 27, 2025
17 checks passed
@ematipico ematipico deleted the fix/actions-context branch March 27, 2025 07:33
@astrobot-houston astrobot-houston mentioned this pull request Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs pr pkg: astro Related to the core `astro` package (scope)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants