-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
feat(cloudflare): global env #13444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cloudflare): global env #13444
Conversation
🦋 Changeset detectedLatest commit: b0d1334 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Do we have to update cloudflare docs by any chance?
|
There's a docs PR removing the astro:env limitation, I don't think we need to update the adapter docs |
I had to enable https://developers.cloudflare.com/workers/configuration/compatibility-flags/#enable-auto-populating-processenv via |
|
@icepuma that indicates it's now on by default though, right? |
|
If you set the So I had to enable the flag manually ( |
|
I thought env from cloudflare:workers was GA, we probably need to ask someone at cloudflare |
|
@icepuma that's about |
|
As I mentioned before, I had to explicitly enable the mentioned flag to get my astro app running, hence why I'm mentioning it |
|
Yeah and that helps thanks. I've asked cloudflare and I'll post updates here |
|
It should definitely not happen. @icepuma can you open an issue with a minimal reproduction? Ideally a gh repo so we can deploy it ourselves to cloudflare |
|
https://github.com/open-source-issues/astro-cloudflare-env-problem this should do the trick. If something is missing, let me know :) |
|
And here's the issue: #13503 |
Changes
astro:envAPIs globally on cloudflareTesting
Should still pass
Docs
withastro/docs#11288