chore: remove deprecated package #13455
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
github-actions
bot
added
the
pkg: astro
ematipico
commented
Mar 18, 2025
Comment on lines
+123
to
+125
| if (value) { | ||
| return new AstroCookie(value); | ||
| } |
There was a problem hiding this comment.
The new type returns Record<string, string | undefined>, so to avoid possible breakages in AstroCookie, I create the type only when the value isn't undefined
florian-lefebvre
approved these changes
Mar 18, 2025
CodSpeed Performance ReportMerging #13455 will not alter performanceComparing Summary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The package
@types/cookieis deprecated, andcookienow ships its own types.This PR removes the deprecated package
@types/cookie, updatescookieand ensures the new types are used. The types are slightly different, so to avoid possible breaking changes I made sure that we createAstroCookiesonly when we have a value.No changeset needed because no logic should change.
Testing
CI should work
Docs
N/A