fix: set correct statusText for custom error pages #13457
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8135ef5 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
|
|
||
| if (status) { | ||
| return new Response(body, { ...init, headers, status }); | ||
| return new Response(body, { ...init, headers, status, statusText }); |
There was a problem hiding this comment.
What if there's a custom status text? this would override it I think
There was a problem hiding this comment.
Hm. Good point. I suppose in theory someone might set a custom status in the custom error page. I'll change ti to only change it if it's "OK"
CodSpeed Performance ReportMerging #13457 will not alter performanceComparing Summary
|
florian-lefebvre
approved these changes
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Currently if a user has a custom
404.astroor500.astrowe set the correct status code in the response, but not the correct status text, instead leaving the defaultOK. This PR ensures the correct text is set too.Fixes #13259
Testing
Added tests
Docs