feat: move astro config validation after astro:config:setup #13482

florian-lefebvre · 2025-03-21T10:20:21Z

Changes

In the config schema, refine and superRefine were only called when validating the user's config
With this PR, those validations are moved to another schema, called for the user config (as before) as well as at the end of astro:config:setup for each integration
Config related schemas are split in several files for clarity
Integrations hooks are refactored
Unhandled errors in integration hooks now log which integration and which hook is failing
I recommend you review the PR without whitespace changes

Testing

Updated, should pass

Docs

Changeset, no docs update needed I think

changeset-bot · 2025-03-21T10:20:26Z

🦋 Changeset detected

Latest commit: ef18425

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codspeed-hq · 2025-03-21T10:32:42Z

CodSpeed Performance Report

Merging #13482 will not alter performance

_{Comparing feat/post-integrations-config-validation (ef18425) with main (b8645c1)}

Summary

✅ 6 untouched benchmarks

github-actions

This PR is blocked because it contains a minor changeset. A reviewer will merge this at the next release if approved.

ematipico

I believe the new names are misleading. Calling the new schema refined isn't correct IMHO, unless I misunderstood its intent. Now that we have a schema that runs after the hooks, we can also run transformations, right? Without affecting downstream integrations.

If so, can we call the new schema post validation or something similar?

packages/astro/src/core/config/schemas/README.md

Co-authored-by: Emanuele Stoppa <[email protected]>

florian-lefebvre · 2025-03-27T08:27:53Z

@ematipico it's called refined on purpose because it only performs a set of checks inside of .superRefine(), there are no transformations happening. I think if we want to be able to do transforms before being stored in settings, that will require another PR (because eg. types will have to added/renamed across a lot of places etc)

ematipico · 2025-03-27T08:30:38Z

Ok, I thought the initial intent of the PR was to allow transformations after validation.

delucis

Thanks for the ping @florian-lefebvre! Left some comments.

.changeset/easy-vans-laugh.md

packages/astro/src/core/config/schemas/README.md

packages/astro/src/integrations/hooks.ts

.changeset/easy-vans-laugh.md

sarah11918

Approving for docs!

merge day

ematipico · 2025-04-02T10:09:08Z

@delucis, I am going to merge this PR. Please let us know if you have concerns.

…o#13482) * feat: move astro config validation after astro:config:setup * feat: superRefine * fix: test * feat: update test * feat: update test * fix: test * feat: feedback * feat: improve logging * feat: refactor * fix: no spread * feat: split schemas * chore: changeset * Update packages/astro/src/core/config/schemas/README.md Co-authored-by: Emanuele Stoppa <[email protected]> * Update packages/astro/src/integrations/hooks.ts * Update packages/astro/src/core/config/schemas/README.md * Update .changeset/easy-vans-laugh.md * Update .changeset/easy-vans-laugh.md * grammar nit in changeset --------- Co-authored-by: Emanuele Stoppa <[email protected]> Co-authored-by: Sarah Rainsberger <[email protected]> Co-authored-by: ematipico <[email protected]> Co-authored-by: delucis <[email protected]> Co-authored-by: sarah11918 <[email protected]>

feat: move astro config validation after astro:config:setup

5fe1889

florian-lefebvre self-assigned this Mar 21, 2025

github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Mar 21, 2025

feat: superRefine

09ba9ce

florian-lefebvre added 2 commits March 21, 2025 11:32

fix: test

d990b07

feat: update test

f0abd11

github-actions bot added the semver: minor Change triggers a `minor` release label Mar 21, 2025

github-actions bot previously requested changes Mar 21, 2025

View reviewed changes

florian-lefebvre added 3 commits March 21, 2025 11:59

feat: update test

27668d3

fix: test

f7699d5

Merge branch 'main' into feat/post-integrations-config-validation

fbaada2

florian-lefebvre marked this pull request as ready for review March 21, 2025 12:06

feat: feedback

d074a51

florian-lefebvre marked this pull request as draft March 21, 2025 14:12

florian-lefebvre mentioned this pull request Mar 26, 2025

fix(fonts): config family types for inferred provider #13469

Merged

florian-lefebvre added 5 commits March 26, 2025 10:58

Merge branch 'main' into feat/post-integrations-config-validation

de52147

feat: improve logging

634696f

feat: refactor

60cffca

fix: no spread

0a3ce47

feat: split schemas

4598ae7

github-actions bot added the docs pr label Mar 26, 2025

florian-lefebvre added 2 commits March 26, 2025 13:30

chore: changeset

a353e4a

Merge branch 'main' into feat/post-integrations-config-validation

4fb9ec1

florian-lefebvre marked this pull request as ready for review March 26, 2025 12:32

florian-lefebvre added this to the v5.6.0 milestone Mar 26, 2025

ematipico reviewed Mar 26, 2025

View reviewed changes

packages/astro/src/core/config/schemas/README.md Outdated Show resolved Hide resolved

Update packages/astro/src/core/config/schemas/README.md

57c55bd

Co-authored-by: Emanuele Stoppa <[email protected]>

Merge branch 'main' into feat/post-integrations-config-validation

3159e7b

ematipico approved these changes Mar 27, 2025

View reviewed changes

delucis reviewed Mar 27, 2025

View reviewed changes

.changeset/easy-vans-laugh.md Show resolved Hide resolved

packages/astro/src/core/config/schemas/README.md Outdated Show resolved Hide resolved

packages/astro/src/integrations/hooks.ts Show resolved Hide resolved

florian-lefebvre added 2 commits March 28, 2025 09:32

Update packages/astro/src/integrations/hooks.ts

a021476

Update packages/astro/src/core/config/schemas/README.md

0a0507e

florian-lefebvre requested a review from delucis March 28, 2025 08:33

sarah11918 reviewed Mar 28, 2025

View reviewed changes

.changeset/easy-vans-laugh.md Outdated Show resolved Hide resolved

sarah11918 reviewed Mar 28, 2025

View reviewed changes

.changeset/easy-vans-laugh.md Outdated Show resolved Hide resolved

florian-lefebvre added 2 commits April 1, 2025 14:27

Update .changeset/easy-vans-laugh.md

f9eb6b1

Update .changeset/easy-vans-laugh.md

01e8518

florian-lefebvre requested a review from sarah11918 April 1, 2025 12:28

Merge branch 'main' into feat/post-integrations-config-validation

e68052d

sarah11918 reviewed Apr 1, 2025

View reviewed changes

.changeset/easy-vans-laugh.md Outdated Show resolved Hide resolved

grammar nit in changeset

ef18425

sarah11918 approved these changes Apr 1, 2025

View reviewed changes

ematipico merged commit ff257df into main Apr 2, 2025
17 checks passed

ematipico deleted the feat/post-integrations-config-validation branch April 2, 2025 10:09

astrobot-houston mentioned this pull request Apr 2, 2025

[ci] release #13540

Merged

delucis mentioned this pull request Apr 3, 2025

Configuration Error with i18n.routing.redirectToDefaultLocale in Starlight #13551

Closed

florian-lefebvre mentioned this pull request Sep 19, 2025

feat(astro)!: update i18n.redirectToDefaultLocale default #14406

Merged

Uh oh!

feat: move astro config validation after astro:config:setup #13482

feat: move astro config validation after astro:config:setup #13482

Uh oh!

Conversation

florian-lefebvre commented Mar 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Testing

Docs

Uh oh!

changeset-bot bot commented Mar 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

codspeed-hq bot commented Mar 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging #13482 will not alter performance

Summary

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

ematipico left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

florian-lefebvre commented Mar 27, 2025

Uh oh!

ematipico commented Mar 27, 2025

Uh oh!

delucis left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sarah11918 left a comment

Choose a reason for hiding this comment

Uh oh!

ematipico commented Apr 2, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

florian-lefebvre commented Mar 21, 2025 •

edited

Loading

changeset-bot bot commented Mar 21, 2025 •

edited

Loading

codspeed-hq bot commented Mar 21, 2025 •

edited

Loading