Skip to content

Conversation

@ascorbic
Copy link
Contributor

@ascorbic ascorbic commented Mar 21, 2025

Changes

Currently there is a strange error on Stackblitz where if the config cannot be loaded because of native addons it fails silently, because it throws an uncatchable error. This PR improves error handling so that those errors can be properly logged. This is not Stackblitz-specific, but does special-case the ERR_DLOPEN_DISABLED error that is thrown. This should be fine, because it's not the sort of error that would ever be recoverable by Vite, as it's due to a setting in Node.

Fixes #13249

Testing

Manually tested on Stackblitz:

https://stackblitz.com/github/ascorbic/withastro-astro-banrd5uv/tree/ascorbic/patch-13439

image

Docs

@changeset-bot
Copy link

changeset-bot bot commented Mar 21, 2025

🦋 Changeset detected

Latest commit: 763c692

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Mar 21, 2025
@ascorbic ascorbic added pr preview Apply this label to a PR to generate a preview release and removed pkg: astro Related to the core `astro` package (scope) labels Mar 21, 2025
@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 21, 2025

astro

npm i https://pkg.pr.new/astro@13484

@astrojs/cloudflare

npm i https://pkg.pr.new/@astrojs/cloudflare@13484

@astrojs/netlify

npm i https://pkg.pr.new/@astrojs/netlify@13484

@astrojs/node

npm i https://pkg.pr.new/@astrojs/node@13484

@astrojs/vercel

npm i https://pkg.pr.new/@astrojs/vercel@13484

commit: e12b62f

@ascorbic ascorbic marked this pull request as ready for review March 21, 2025 13:15
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 21, 2025

CodSpeed Performance Report

Merging #13484 will not alter performance

Comparing dlopen-error (763c692) with main (e9e9245)

Summary

✅ 6 untouched benchmarks

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Mar 21, 2025
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Nice comment :)

@ascorbic ascorbic merged commit 8b5e4dc into main Mar 21, 2025
16 checks passed
@ascorbic ascorbic deleted the dlopen-error branch March 21, 2025 14:01
@astrobot-houston astrobot-houston mentioned this pull request Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: astro Related to the core `astro` package (scope) pr preview Apply this label to a PR to generate a preview release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Astro with Tailwind integration failed to start on StackBlitz.com

2 participants