fix: cache raw cookie value and decode when getting

.changeset/honest-loops-cheat.md

@@ -0,0 +1,5 @@
+---
+'astro': patch
+---
+
+Fixes a bug that caused cookies to ignore custom decode function if has() had been called before

packages/astro/src/core/cookies/cookies.ts

@@ -35,6 +35,8 @@ const DELETED_EXPIRATION = new Date(0);
 const DELETED_VALUE = 'deleted';
 const responseSentSymbol = Symbol.for('astro.responseSent');
 
+const identity = (value: string) => value;
+
 class AstroCookie implements AstroCookieInterface {
 	constructor(public value: string) {}
 	json() {
@@ -117,11 +119,13 @@ class AstroCookies implements AstroCookiesInterface {
 			}
 		}
 
-		const values = this.#ensureParsed(options);
+		const decode = options?.decode ?? decodeURIComponent
+
+		const values = this.#ensureParsed();
 		if (key in values) {
 			const value = values[key];
 			if (value) {
-				return new AstroCookie(value);
+				return new AstroCookie(decode(value));
 			}
 		}
 	}
@@ -130,15 +134,16 @@ class AstroCookies implements AstroCookiesInterface {
 	 * Astro.cookies.has(key) returns a boolean indicating whether this cookie is either
 	 * part of the initial request or set via Astro.cookies.set(key)
 	 * @param key The cookie to check for.
+	 * @param _options This parameter is no longer used.
 	 * @returns
 	 */
-	has(key: string, options: AstroCookieGetOptions | undefined = undefined): boolean {
+	has(key: string, _options?: AstroCookieGetOptions): boolean {
 		if (this.#outgoing?.has(key)) {
 			let [, , isSetValue] = this.#outgoing.get(key)!;
 			return isSetValue;
 		}
-		const values = this.#ensureParsed(options);
-		return !!values[key];
+		const values = this.#ensureParsed();
+		return values[key] !== undefined;
 	}
 
 	/**
@@ -227,11 +232,9 @@ class AstroCookies implements AstroCookiesInterface {
 		return cookies.headers();
 	}
 
-	#ensureParsed(
-		options: AstroCookieGetOptions | undefined = undefined,
-	): Record<string, string | undefined> {
+	#ensureParsed(): Record<string, string | undefined> {
 		if (!this.#requestValues) {
-			this.#parse(options);
+			this.#parse();
 		}
 		if (!this.#requestValues) {
 			this.#requestValues = {};
@@ -246,13 +249,14 @@ class AstroCookies implements AstroCookiesInterface {
 		return this.#outgoing;
 	}
 
-	#parse(options: AstroCookieGetOptions | undefined = undefined) {
+	#parse() {
 		const raw = this.#request.headers.get('cookie');
 		if (!raw) {
 			return;
 		}
-
-		this.#requestValues = parse(raw, options);
+		// Pass identity function for decoding so it doesn't use the default.
+		// We'll do the actual decoding when we read the value.
+		this.#requestValues = parse(raw, { decode: identity });
 	}
 }