Skip to content

Conversation

@florian-lefebvre
Copy link
Member

@florian-lefebvre florian-lefebvre commented Apr 2, 2025

Changes

  • Addresses feedback from the API bash
  • Removes the as prop. Instead, we generate a new nameWithHash (hash computed from the family config object) property to avoid conflicts if the same font name is specified more than once
  • Adds a new required cssVariable property. That gives control to the user and avoids having to guess. There's minimal validation, that should handle most mistakes
  • It simplifies a lot of things by removing some checks and errors that are now unecessary

Testing

Manual and automated

Docs

RFC updated

@florian-lefebvre florian-lefebvre self-assigned this Apr 2, 2025
@changeset-bot
Copy link

changeset-bot bot commented Apr 2, 2025

⚠️ No Changeset found

Latest commit: 8bcc1d0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) docs pr labels Apr 2, 2025
@florian-lefebvre florian-lefebvre marked this pull request as ready for review April 2, 2025 16:20
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool seeing the deleted code here! 🙌

@florian-lefebvre florian-lefebvre requested a review from delucis April 3, 2025 08:02
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good I think!

Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to handle errors coming from the resolution of font providers

@florian-lefebvre florian-lefebvre merged commit c22561c into feat/fonts Apr 3, 2025
14 checks passed
@florian-lefebvre florian-lefebvre deleted the feat/fonts-css-variable branch April 3, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs pr pkg: astro Related to the core `astro` package (scope)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants