-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
feat(fonts): new cssVariable property #13544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool seeing the deleted code here! 🙌
Co-authored-by: Chris Swithinbank <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good I think!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to handle errors coming from the resolution of font providers
Changes
asprop. Instead, we generate a newnameWithHash(hash computed from the family config object) property to avoid conflicts if the same font name is specified more than oncecssVariableproperty. That gives control to the user and avoids having to guess. There's minimal validation, that should handle most mistakesTesting
Manual and automated
Docs
RFC updated