fix(svg): prevent empty attributes #13545
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b366883 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
CodSpeed Performance ReportMerging #13545 will not alter performanceComparing Summary
|
ematipico
approved these changes
Apr 3, 2025
|
@ematipico please take another look at these changes. Verified the fix on ultrahtml side and the test still passes |
ematipico
approved these changes
Apr 4, 2025
Merged
openscript
pushed a commit
to openscript/astro
that referenced
this pull request
Sep 12, 2025
* fix(svg): prevent empty attributes * create changeset * bump ultrahtml instead Co-authored-by: ematipico <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Updating to the latest 1.6.0 which fixes the issue and brings in some optimizations to the regexes it uses.
Fixes #13496
Testing
Added a test to assert that there were no empty attributes
=""in the resultant html with an SVG known to produce it.Docs
Not necessary as this is just a bug fix.