Skip to content

feat(fonts): improve local font files deletion #13559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: feat(fonts): experimental release
merged 2 commits into from
Apr 4, 2025
Merged

feat(fonts): improve local font files deletion #13559

merged 2 commits into from
Apr 4, 2025

Conversation

@florian-lefebvre
Copy link
Member

Changes

  • Addresses feedback from Chris
  • With this PR, we don't throw an error in dev if a local font file used is deleted. Instead we show a warning in the terminal
  • Allows to remove a bunch of code

Testing

Updated and manual

Docs

N/A

@florian-lefebvre florian-lefebvre self-assigned this Apr 4, 2025
@changeset-bot
Copy link

changeset-bot bot commented Apr 4, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: f81e4fa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) docs pr labels Apr 4, 2025
ematipico
ematipico approved these changes Apr 4, 2025
View reviewed changes
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just need to make the message a bit more actionable

@florian-lefebvre florian-lefebvre merged commit 0362529 into feat/fonts Apr 4, 2025
3 of 4 checks passed
@florian-lefebvre florian-lefebvre deleted the feat/fonts-better-deletion-handling branch April 4, 2025 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ematipico ematipico ematipico approved these changes

Assignees

@florian-lefebvre florian-lefebvre

Labels

docs pr pkg: astro Related to the core `astro` package (scope)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@florian-lefebvre @ematipico