fix(fonts): patch unifont #13574
fix(fonts): patch unifont #13574
Conversation
|
| const font = googleFonts.find((font2) => font2.family === family); | ||
| const styles = [...new Set(options.styles.map((i) => styleMap[i]))].sort(); | ||
| - const variableWeight = font.axes.find((a) => a.tag === "wght"); | ||
| + const variableWeight = options.weights.some(weight => weight.includes(" ")) && font.axes.find((a) => a.tag === "wght"); |
There was a problem hiding this comment.
I don't know the library and its types. I just wonder if we could use the optional chain operator to make the patch safer e.g. options.weight?., font.axes?., etc.
There was a problem hiding this comment.
options.weights will always be defined. I don't know about font.axes but I think it's okay to let it as is since it's the same as before the patch
2 participants
Changes
Testing
Manual
Docs
N/A