fix: solving #13577 #13587
Merged
fix: solving #13577 #13587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7e5757f The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
1 task
CodSpeed Performance ReportMerging #13587 will not alter performanceComparing Summary
|
martrapp
approved these changes
Apr 9, 2025
There was a problem hiding this comment.
Hi @robertoms99 thank you so much for the PR!
Looks very good and I also appreciate the improved naming.
I only suggest the changeset to be a bit more in line with what we typically write ;-)
Co-authored-by: Martin Trapp <[email protected]>
Merged
|
Really appreciate you spotting that and fixing it! Thanks again! |
openscript
pushed a commit
to openscript/astro
that referenced
this pull request
Sep 12, 2025
* fix: solving withastro#13577 * Update .changeset/yellow-dogs-say.md Co-authored-by: Martin Trapp <[email protected]> --------- Co-authored-by: Martin Trapp <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Avoiding preserve
data-astro-*attrs other thandata-astro-transitionanddata-astro-transition-fallbackwhen usingswapRootAttributes#135577Fixes #13577
Testing
Running packages/astro/e2e/view-transitions.test.js
Docs
It' s a patch
martrapp: bug fix, n/a