Skip to content

feat(fonts): T&D feedback #13597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: feat(fonts): experimental release
merged 2 commits into from
Apr 10, 2025
Merged

feat(fonts): T&D feedback #13597

merged 2 commits into from
Apr 10, 2025

Conversation

@florian-lefebvre
Copy link
Member

@florian-lefebvre florian-lefebvre commented Apr 10, 2025 •
edited
Loading

Changes

  • Addresses feedback from T&D
  • Renames Font component family to cssVariable
  • Renames font configuration automaticFallback to optimizedFallbacks

Testing

Should pass

Docs

RFC updated

@florian-lefebvre florian-lefebvre self-assigned this Apr 10, 2025
@changeset-bot
Copy link

changeset-bot bot commented Apr 10, 2025

⚠️ No Changeset found

Latest commit: 484860f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Apr 10, 2025
@florian-lefebvre florian-lefebvre marked this pull request as ready for review April 10, 2025 14:56
@florian-lefebvre florian-lefebvre changed the title feat: rename family to cssVariable feat(fonts): T&D feedback Apr 10, 2025
sarah11918
sarah11918 approved these changes Apr 10, 2025
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for docs 😅

@florian-lefebvre florian-lefebvre merged commit d44e4f1 into feat/fonts Apr 10, 2025
14 checks passed
@florian-lefebvre florian-lefebvre deleted the feat/fonts-docs-feedback branch April 10, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sarah11918 sarah11918 sarah11918 approved these changes

Assignees

@florian-lefebvre florian-lefebvre

Labels

pkg: astro Related to the core `astro` package (scope)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@florian-lefebvre @sarah11918