Skip to content

feat(fonts): jsdocs #13600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: feat(fonts): experimental release
merged 7 commits into from
Apr 11, 2025
Merged

feat(fonts): jsdocs #13600

merged 7 commits into from
Apr 11, 2025

Conversation

@florian-lefebvre
Copy link
Member

Changes

  • Adds jsdocs

Testing

Docs

@florian-lefebvre florian-lefebvre self-assigned this Apr 10, 2025
@changeset-bot
Copy link

changeset-bot bot commented Apr 10, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 163cd7c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) docs pr labels Apr 10, 2025
sarah11918
sarah11918 reviewed Apr 10, 2025
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are some thoughts! Looking really good!

ArmandPhilippot
ArmandPhilippot reviewed Apr 10, 2025
View reviewed changes
@florian-lefebvre @ArmandPhilippot
Apply suggestions from code review
5985c00 
Co-authored-by: Armand Philippot <[email protected]>
sarah11918
sarah11918 approved these changes Apr 11, 2025
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment •
edited by florian-lefebvre
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. All comments seem addressed, it's go time! 🚀

@florian-lefebvre florian-lefebvre merged commit be114f2 into feat/fonts Apr 11, 2025
15 checks passed
@florian-lefebvre florian-lefebvre deleted the feat/fonts-jsdocs branch April 11, 2025 09:56
@florian-lefebvre florian-lefebvre mentioned this pull request Apr 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sarah11918 sarah11918 sarah11918 approved these changes

@ArmandPhilippot ArmandPhilippot Awaiting requested review from ArmandPhilippot

Assignees

@florian-lefebvre florian-lefebvre

Labels

docs pr pkg: astro Related to the core `astro` package (scope)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@florian-lefebvre @sarah11918 @ArmandPhilippot