Skip to content

Conversation

@sarah11918
Copy link
Member

@sarah11918 sarah11918 commented Apr 14, 2025

Changes

This adds the @message property (and message to the ErrorData object) for one of the new error messages. @florian-lefebvre or someone please correct/verify the actual content!

Testing

Not tested, but the @message property is the one that generates the error message block in docs. Without it, we only get a "What went wrong?" section. (This might also affect the error message people see?)

e.g. without: (we had one slip by earlier!)
image

vs most other error messages:
image

Docs

All for docs!

@changeset-bot
Copy link

changeset-bot bot commented Apr 14, 2025

⚠️ No Changeset found

Latest commit: 2e1a5d5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) docs pr labels Apr 14, 2025
Copy link
Member

@florian-lefebvre florian-lefebvre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error usage must be updated too, I'll look into it when I can

Copy link
Member

@florian-lefebvre florian-lefebvre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests should pass

@codspeed-hq
Copy link

codspeed-hq bot commented Apr 15, 2025

CodSpeed Performance Report

Merging #13612 will not alter performance

Comparing sarah11918-patch-3 (f3ed12b) with main (29ab38e)

Summary

✅ 6 untouched benchmarks

@florian-lefebvre florian-lefebvre merged commit 93470a1 into main Apr 15, 2025
16 checks passed
@florian-lefebvre florian-lefebvre deleted the sarah11918-patch-3 branch April 15, 2025 07:06
openscript pushed a commit to openscript/astro that referenced this pull request Sep 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs pr pkg: astro Related to the core `astro` package (scope)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants