Skip to content

fix: improve autocomplete for session keys #13622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2025
+7 −2
Merged

fix: improve autocomplete for session keys #13622

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/young-peaches-serve.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'astro': patch
---

Improve autocomplete for session keys
4 changes: 2 additions & 2 deletions packages/astro/src/core/session.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ export class AstroSession<TDriver extends SessionDriverName = any> {
/**
* Gets a session value. Returns `undefined` if the session or value does not exist.
*/
async get<T = void, K extends string = string>(
async get<T = void, K extends string = keyof App.SessionData | (string & {}) >(
key: K,
): Promise<
(T extends void ? (K extends keyof App.SessionData ? App.SessionData[K] : any) : T) | undefined
Expand Down Expand Up @@ -153,7 +153,7 @@ export class AstroSession<TDriver extends SessionDriverName = any> {
* Sets a session value. The session is created if it does not exist.
*/

set<T = void, K extends string = string>(
set<T = void, K extends string = keyof App.SessionData | (string & {})>(
key: K,
value: T extends void
? K extends keyof App.SessionData
Expand Down