Skip to content

Conversation

@jonaspm
Copy link
Contributor

@jonaspm jonaspm commented Apr 15, 2025

Changes

Upgraded drizzle-orm to latest v0.42.0

Testing

Docs

Changeset

@changeset-bot
Copy link

changeset-bot bot commented Apr 15, 2025

🦋 Changeset detected

Latest commit: 0c7cccf

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

florian-lefebvre and others added 10 commits April 16, 2025 09:59
Co-authored-by: Sarah Rainsberger <[email protected]>
Co-authored-by: Chris Swithinbank <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* feat(fonts): fallback improvements

* feat: improve fallbacks generation

* chore: comments

* Update packages/astro/src/assets/fonts/utils.ts

Co-authored-by: Emanuele Stoppa <[email protected]>

* Apply suggestions from code review

Co-authored-by: Sarah Rainsberger <[email protected]>

---------

Co-authored-by: Emanuele Stoppa <[email protected]>
Co-authored-by: Sarah Rainsberger <[email protected]>
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jonaspm. The code doesn't build anymore, can you please fix it?

astrobot-houston and others added 16 commits April 16, 2025 15:38
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* update create-astro minimal template wording

* Create chilled-pears-know.md

* template vs project, to better distinguish it from basics

* consistent use of "Use" with other non-recommended templates

* Update packages/create-astro/src/actions/template.ts

Co-authored-by: Sarah Rainsberger <[email protected]>

---------

Co-authored-by: Matt Kane <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added pkg: svelte Related to Svelte (scope) pkg: vue Related to Vue (scope) pkg: example Related to an example package (scope) 🚨 action Modifies GitHub Actions pkg: react Related to React (scope) pkg: preact Related to Preact (scope) pkg: solid Related to Solid (scope) pkg: integration Related to any renderer integration (scope) pkg: create-astro Related to the `create-astro` package (scope) pkg: astro Related to the core `astro` package (scope) docs pr labels May 16, 2025
@ematipico
Copy link
Member

Something went wrong @jonaspm , can you please fix the PR?

@jonaspm
Copy link
Contributor Author

jonaspm commented May 16, 2025

Something went wrong @jonaspm , can you please fix the PR?

I did a rebase, still working on fixing build. @ematipico should I open a new PR?

@ematipico
Copy link
Member

You're free to do whatever you want 😉

… safety.

- Drizzle added more column properties, therefore typescript yells about minimal intersection between types.
@codspeed-hq
Copy link

codspeed-hq bot commented May 17, 2025

CodSpeed Performance Report

Merging #13628 will not alter performance

Comparing jonaspm:main (0c7cccf) with main (866285a)

Summary

✅ 6 untouched benchmarks

@jonaspm jonaspm requested a review from ematipico May 17, 2025 09:18
@jonaspm jonaspm closed this May 17, 2025
@jonaspm
Copy link
Contributor Author

jonaspm commented May 17, 2025

Closed in favor of #13815

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🚨 action Modifies GitHub Actions docs pr pkg: astro Related to the core `astro` package (scope) pkg: create-astro Related to the `create-astro` package (scope) pkg: example Related to an example package (scope) pkg: integration Related to any renderer integration (scope) pkg: preact Related to Preact (scope) pkg: react Related to React (scope) pkg: solid Related to Solid (scope) pkg: svelte Related to Svelte (scope) pkg: vue Related to Vue (scope)

Projects

None yet

Development

Successfully merging this pull request may close these issues.