-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
feat(fonts): fallback improvements #13632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 16b1478 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
CodSpeed Performance ReportMerging #13632 will not alter performanceComparing Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I left nitpicks, but you can merge away :) One suggestion: let's put more description in the changeset, at least let's explain that these changes affect the experimental Fonts API.
Co-authored-by: Emanuele Stoppa <[email protected]>
Co-authored-by: Sarah Rainsberger <[email protected]>
* feat(fonts): fallback improvements * feat: improve fallbacks generation * chore: comments * Update packages/astro/src/assets/fonts/utils.ts Co-authored-by: Emanuele Stoppa <[email protected]> * Apply suggestions from code review Co-authored-by: Sarah Rainsberger <[email protected]> --------- Co-authored-by: Emanuele Stoppa <[email protected]> Co-authored-by: Sarah Rainsberger <[email protected]>
Changes
@capsizecss/metricspackage (which is huge and was removed in fix(fonts): lighter fallbacks #13626)Testing
Tests added
Docs
Changesets