Skip to content

Conversation

@florian-lefebvre
Copy link
Member

@florian-lefebvre florian-lefebvre commented Apr 16, 2025

Changes

  • RFC feedback
  • Before this PR, we were generating 1 fallback @font-face definition based on the first font file we found for a given family
  • However, it wasn't great because the fallback would only be accurate for a given weight/style which was defeating its purpose
  • Now we generate a fallback for each weight/style
  • Fixes a few cases where useless duplicate fallbacks could be created

Testing

Tests updated, tested manually

Docs

Changeset

@florian-lefebvre florian-lefebvre self-assigned this Apr 16, 2025
@changeset-bot
Copy link

changeset-bot bot commented Apr 16, 2025

🦋 Changeset detected

Latest commit: a49b1d9

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Apr 16, 2025
@florian-lefebvre florian-lefebvre added the pr preview Apply this label to a PR to generate a preview release label Apr 16, 2025
@github-actions github-actions bot removed the pr preview Apply this label to a PR to generate a preview release label Apr 16, 2025
@pkg-pr-new
Copy link

pkg-pr-new bot commented Apr 16, 2025

astro

npm i https://pkg.pr.new/astro@13635

@astrojs/cloudflare

npm i https://pkg.pr.new/@astrojs/cloudflare@13635

@astrojs/netlify

npm i https://pkg.pr.new/@astrojs/netlify@13635

@astrojs/node

npm i https://pkg.pr.new/@astrojs/node@13635

@astrojs/vercel

npm i https://pkg.pr.new/@astrojs/vercel@13635

commit: 5d89da8

@florian-lefebvre
Copy link
Member Author

@jlarmstrongiv can you try the preview release?

@codspeed-hq
Copy link

codspeed-hq bot commented Apr 16, 2025

CodSpeed Performance Report

Merging #13635 will not alter performance

Comparing feat/fonts-fallbacks-for-all-faces (a49b1d9) with main (6744842)

Summary

✅ 6 untouched benchmarks

@jlarmstrongiv
Copy link

@florian-lefebvre is there an npm tag to install the prerelease?

@florian-lefebvre
Copy link
Member Author

We use pkg.pr.new, the command is in a collapsed part of a message above:

npm i https://pkg.pr.new/astro@13635

@florian-lefebvre florian-lefebvre marked this pull request as ready for review April 18, 2025 10:01
@florian-lefebvre florian-lefebvre merged commit d75cac4 into main Apr 18, 2025
5 checks passed
@florian-lefebvre florian-lefebvre deleted the feat/fonts-fallbacks-for-all-faces branch April 18, 2025 12:09
@astrobot-houston astrobot-houston mentioned this pull request Apr 17, 2025
openscript pushed a commit to openscript/astro that referenced this pull request Sep 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: astro Related to the core `astro` package (scope)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants