-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
feat(fonts): refactor #13653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(fonts): refactor #13653
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly, it's very hard to find the bug fixes in this huge refactor. As long as tests pass, it's fine. However, I don't have the energy to look at all the code. Take this review with a grain of salt and don't count on it, please.
packages/astro/src/assets/fonts/implementations/css-renderer.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The folders implementations/ and logic/ have an unusual name. We usually name the folders by feature, but in this case, it's hard to understand which "feature" belongs to. Maybe consider a main folder called fonts/ and then have everything there
Changes
@astrojs/vite-plugin-fontsTesting
As a result, there are more/better tests which is always good!
Docs
No behavior change so no docs change! Changesets tho