Skip to content

Conversation

@mingjunlu
Copy link
Contributor

Changes

  • This PR adds server.allowedHosts docs comment to AstroUserConfig

Testing

  • N/A

Docs

@changeset-bot
Copy link

changeset-bot bot commented Apr 20, 2025

🦋 Changeset detected

Latest commit: 0af7f6d

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) docs pr labels Apr 20, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Apr 20, 2025

CodSpeed Performance Report

Merging #13660 will not alter performance

Comparing fix/add-server-allowed-hosts-docs-comment-to-astro-user-config (0af7f6d) with main (d75cac4)

Summary

✅ 6 untouched benchmarks

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for docs! Thank you @mingjunlu 🚀

Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sarah11918 how about having a README.md that explains how to author new configuration fields?

@ematipico ematipico merged commit 620d15d into main Apr 22, 2025
17 checks passed
@ematipico ematipico deleted the fix/add-server-allowed-hosts-docs-comment-to-astro-user-config branch April 22, 2025 09:20
@astrobot-houston astrobot-houston mentioned this pull request Apr 22, 2025
@sarah11918
Copy link
Member

@ematipico Great idea! Would you be willing to make a docs discussion with content you think would be helpful to have there? https://github.com/withastro/docs/discussions/

openscript pushed a commit to openscript/astro that referenced this pull request Sep 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs pr pkg: astro Related to the core `astro` package (scope)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

server.allowedHosts not documented in the config reference

3 participants