-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
feat: convert integrations to TS #13663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 77d5f9b The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| '@astrojs/vue': patch | ||
| --- | ||
|
|
||
| Improves type-safety of renderers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically a changeset is not required since it's a refactor but I prefer to add one here to play it safe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
e2e tests are failing
|
a19a185#diff-ba61f66c23d3acf1a091d002e9c3e9b206bab065742b39149717d21926c13651R43 This change makes the type of container.addServerRenderer({
renderer: reactRenderer,
name: "@astrojs/react",
});now fails with: Had to revert back to react 4.2.4 for now. |
|
@eikowagenknecht can you please create an issue? |
|
Done, #13712 |
Changes
Testing
Should still pass
Docs
Changeset