fix(vercel): handle SVG images correctly in build image service #13679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the Vercel build image service to correctly handle ESM-imported SVG images by returning the original source path, preventing incorrect URL generation. Also aligns the isESMImportedImage utility with the core Astro implementation. Fixes withastro#13664
🦋 Changeset detectedLatest commit: 1ed1e44 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: integration
ascorbic
reviewed
Apr 29, 2025
ascorbic
reviewed
Apr 29, 2025
1 task
florian-lefebvre
approved these changes
Jun 3, 2025
Merged
openscript
pushed a commit
to openscript/astro
that referenced
this pull request
Sep 12, 2025
…astro#13679) Co-authored-by: Matt Kane <[email protected]> Co-authored-by: Florian Lefebvre <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the Vercel build image service to correctly handle ESM-imported SVG images by returning the original source path, preventing incorrect URL generation. Also aligns the isESMImportedImage utility with the core Astro implementation.
Fixes #13664
Changes
isESMImportedImageinpackages/integrations/vercel/src/image/shared.tsto align with the core Astro implementation, correctly identifying SVGs imported as functions.getURLinpackages/integrations/vercel/src/image/build-service.tsto return the originalsrcpath for SVG images, bypassing the Vercel image processing endpoint for them.Testing
This change was tested manually by reproducing the scenario described in issue #13664:
imageService: true.).<img>tag had a corruptedsrcattribute pointing to/_vercel/image?url=(stringified function)....<img>tag correctly points directly to the processed SVG file path (e.g.,/_astro/image.hash.svg).No automated tests were added as this addresses a specific interaction between markdown processing, ESM image imports, and the Vercel build service logic. Existing integration tests for Vercel image handling should continue to pass.
Docs
No documentation changes are needed. This fix addresses an internal bug in the Vercel integration's image service logic and does not change any user-facing APIs or behavior (other than correcting the bug).