feat(@astro/sitemap): custom sitemaps #13682
Conversation
🦋 Changeset detectedLatest commit: 05035f2 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: integration
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
There was a problem hiding this comment.
Thank you for your contribution @gouravkhunger
There are some things to address:
- changeset: needs a better description for our users
- needs more test cases
- developers are in charge of the documentation, so you would need to send a PR to
withastro/docs, this page https://docs.astro.build/en/guides/integrations-guide/sitemap/
gouravkhunger
force-pushed
the
custom-sitemaps
branch
from
3fcb869 to
93c5caf
Compare
gouravkhunger
force-pushed
the
custom-sitemaps
branch
from
93c5caf to
0d94388
Compare
|
Hi @ematipico gentle nudge: this PR has been up for quite some time now. I had replied to your last review. maybe there was a misunderstanding on the scope of this PR. I'm happy to discuss. Thanks! |
There was a problem hiding this comment.
I just did a tiny bit of light editing to make it sound more like our typical style, but y'all should please correct if anything here is wrong or misleading!
Thanks for the great work providing extra information @gouravkhunger, and I'm making some similar style edits to the docs PR now! 🙌
Co-authored-by: Sarah Rainsberger <[email protected]>
There was a problem hiding this comment.
Approving for docs! Thanks for contributing this helpful feature @gouravkhunger 🚀
Co-authored-by: Sarah Rainsberger <[email protected]> Co-authored-by: Emanuele Stoppa <[email protected]>
4 participants
Changes
The sitemap plugin generates
sitemap-${i}.xmland adds all those urls tositemap-index.xml. It already supportscustomPageswhich are auto appended to the urls.This PR introduces the
customSitemapsoption which appends external sitemaps to thesitemap-index.xmlfile along with thesitemap-${i}.xmlentries.Ability to add
customSitemapsis important because in my case I host multiple services under the same domain proxied by nginx:example.com(made with astro),example.com/blog(made with ghost, etc.). So I need to be able to addexample.com/blog/sitemap.xmlto the defaultsitemap-index.xmlfile.Testing
customPagesoptions.Docs
withastro/docs#11563