Skip to content

Conversation

@Le0Developer
Copy link
Contributor

@Le0Developer Le0Developer commented Apr 26, 2025

Changes

' is HTML escaped to ' so the match regex failed.

Fixes #13691

Testing

Tested this myself with the image I originally reported.
Not sure how to add tests for this, the CONTRIBUTING guide only includes how to run tests, but has no details where to add new ones.

Docs

This is a bug fix.

@changeset-bot
Copy link

changeset-bot bot commented Apr 26, 2025

🦋 Changeset detected

Latest commit: 72b80a9

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Apr 26, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Apr 26, 2025

CodSpeed Performance Report

Merging #13692 will not alter performance

Comparing Le0Developer:fix/issue-13691 (72b80a9) with main (0cd3f32)

Summary

✅ 6 untouched benchmarks

@ematipico
Copy link
Member

@Le0Developer

For tests, we have a fixture here: https://github.com/withastro/astro/tree/main/packages/astro/test/fixtures/core-image you can add an image with the apostrophe and a markdown file that imports it

Then update this file with a new test assertion. You can use the other test assertions to understand how to test yours: https://github.com/withastro/astro/blob/main/packages/astro/test/core-image.test.js

@Le0Developer
Copy link
Contributor Author

Added a test. Also verified it failed before the patch.

@ematipico ematipico merged commit 60d5be4 into withastro:main Apr 28, 2025
5 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Apr 28, 2025
@Le0Developer Le0Developer deleted the fix/issue-13691 branch April 28, 2025 12:39
openscript pushed a commit to openscript/astro that referenced this pull request Sep 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: astro Related to the core `astro` package (scope)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

specific authorized remote image in markdown breaks dev preview and building

2 participants