-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
feat(fonts): update unifont #13705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(fonts): update unifont #13705
Conversation
🦋 Changeset detectedLatest commit: 690edae The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
CodSpeed Performance ReportMerging #13705 will not alter performanceComparing Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we have a JSDoc and a return type for the orchestrate function? It's very big, we don't know what it does (orchestrate is a very generic term), and now we changed its return type, where we also changed internal variables, in which some comments were lost
|
The
Because yes comments were not lost but moved to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Apologies I missed the JSDoc attached to the function
Changes
meta.inittype to FontFaceData unjs/unifont#155)init, I chose to usenullinstead of an optional property to make sure we pass it through everythingTesting
orchestratetest to make sureinitis well forwarded to the endDocs
Changeset