fix: recursive content schema types #13706
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 860d3f2 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
ascorbic
force-pushed
the
recursive-schema-types
branch
from
b6c075f to
860d3f2
Compare
florian-lefebvre
approved these changes
Apr 28, 2025
ematipico
approved these changes
Apr 28, 2025
|
The fix is that previously the recursive type meant that the type-checker gave up and typed This PR gets rid of the recursion. The price is that it no longer attempts to type-check unions of unions, but as previously it wasn't type-checking anything, that's not a loss! |
|
...and now: |
Merged
1 task
openscript
pushed a commit
to openscript/astro
that referenced
this pull request
Sep 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Currently the way that
BaseSchemaWithoutEffectsis defined means that it's infinitely recursive, causing TypeScript to bail and type it asany. This means that there's no proper typechecking on content config schema, and was also making it hard to type live content loaders. This PR should fix that: it splits the composite types out. It no longer uses recursive types for allowed unions, but instead allows unions of non-unions, but also allows unions of any other unions. We don't check those deep unions anymore because wtf calm down stop being mean to TypeScript.Testing
Tested both with the examples, but also the docs site and manually with various combinations.
Docs