Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/little-jokes-rhyme.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'astro': patch
---

Fix cookies set after middleware did a rewrite with `next(url)` not being applied
1 change: 0 additions & 1 deletion packages/astro/src/core/render-context.ts
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,6 @@ export class RenderContext {
}
this.isRewriting = true;
this.url = new URL(this.request.url);
this.cookies = new AstroCookies(this.request);
this.params = getParams(routeData, pathname);
this.pathname = pathname;
this.status = 200;
Expand Down
7 changes: 7 additions & 0 deletions packages/astro/test/astro-cookies.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -194,5 +194,12 @@ describe('Astro.cookies', () => {
assert.equal(response.status, 200);
assert.match(response.headers.get('Set-Cookie'), /test=value/);
});

it('can set cookies in a rewritten endpoint request from middleware', async () => {
const request = new Request('http://example.com/rewrite-me');
const response = await app.render(request, { addCookieHeader: true });
assert.equal(response.status, 200);
assert.match(response.headers.get('Set-Cookie'), /my_cookie=value/);
});
});
});
9 changes: 9 additions & 0 deletions packages/astro/test/fixtures/astro-cookies/src/middleware.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
import { defineMiddleware } from "astro:middleware";

export const onRequest = defineMiddleware((ctx, next) => {
if (ctx.url.pathname === "/rewrite-me") {
return next("/rewrite-target");
} else {
return next();
}
})