refactor(example): remove todo comment and normalize network errors

[jp-knj]

Changes

• remove todo comment

• Renamed helper
  get<T> → getJson<T> to clarify that the helper always returns parsed JSON.

• Timeout & abort support
  Adds an AbortController with a 10 s default timeout to prevent hanging requests.

• Richer error messages

  • Distinguishes HTTP errors (GET /api … → 503) from network/abort errors (failed: The user aborted a request).
  • Includes status text for quicker debugging.

• Less boilerplate
  Helper now returns response.json() directly, so the four public API functions no longer need their own inline callbacks.

• No functional change to callers
  Signatures of getProducts(), getProduct(), getUser(), and getCart() remain identical; only internal implementation is updated.

• Changeset included
  pnpm exec changeset this is purely internal refactor. not add.

Testing

• Unit: pnpm test — all existing tests pass.
• Manual:
  1. Started dev server, loaded /products page – data still renders.
  2. Throttled network in DevTools → request now aborts at 10 s with descriptive console error.
  3. Verified addToUserCart() still posts successfully.

No new automated tests added because the helper is already covered by higher-level API tests; timeout behaviour is best validated manually.

Docs

No public-facing API surface changed, so docs update not required.

/cc @withastro/maintainers-docs for visibility, but I believe no docs edits are needed.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 783acf3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[ematipico]

Can you please update the example to show the usage of the new parameter timeout? This is an example, so we need to show the usage of things that we write

[jp-knj]

@ematipico
Sorry for the delay—just pushed an update
Please review again,

that highlights the new timeout parameter in real calls.

/********************************************************************
 * example.ts – showing the new `timeout` option in action
 *******************************************************************/

// Assume getJSON + helpers are imported from your library:
//
//   import { getProducts, getProduct, addToUserCart } from './api';

async function demo(req: Request) {
  try {
    // 1) Short-fuse fetch: if your catalog service is slow, fail fast.
    const products = await getProducts(req, { timeout: 3_000 });
    console.log('products loaded in ≤3 s:', products.length);

    // 2) Normal fetch – keep the default 10 s timeout.
    const game = await getProduct(req, 42);
    console.log('single product:', game);

    // 3) POST helper also accepts timeout (and signal, base, …).
    await addToUserCart(42, 'Space Adventure', { timeout: 5_000 });
    console.log('cart updated!');
  } catch (err) {
    console.error('Request aborted or failed:', err);
  }
}

Call	Timeout behaviour
getProducts(req, { timeout: 3000 })	Aborts after 3 s if the list API hasn’t replied.
getProduct(req, 42)	Uses the helper’s default 10 s timeout.
addToUserCart(…, { timeout: 5000 })	Aborts the POST after 5 s if the cart API hasn’t replied.

This shows exactly how consumers pass the new option while keeping the helper’s surface minimal: just an options object whose timeout key is optional.

[florian-lefebvre]

Can you remove the changesets? Changesets are only for modifications of packages, not examples

[jp-knj]

@florian-lefebvre

Can you remove the changesets? Changesets are only for modifications of packages, not examples

Sure, updated it.

[florian-lefebvre]

Thanks for removing one changeset! There's another one to remove too

[florian-lefebvre]

Since the timeout isn't used, i think it could be worth removing it altogether from the example. We try to keep examples minimal and as a starting point. So that probably means removing the abort controller too

[jp-knj]

Got it, Just a moment.

[jp-knj]

@florian-lefebvre
I'm done, just keep simple. is it still Okay?

[florian-lefebvre]

Thanks!