refactor(astro): Replaced generic Error throws with AstroError
#13759
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4df12d2 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
jp-knj
changed the title
Error throws with `AstroErrorError throws with AstroError
CodSpeed Performance ReportMerging #13759 will not alter performanceComparing Summary
|
Merged
|
Hi @jp-knj thanks for the PR! We follow a pattern for errors that is putting them in https://github.com/withastro/astro/blob/main/packages/astro/src/core/errors/errors-data.ts. Would you mind opening another PR for this? |
openscript
pushed a commit
to openscript/astro
that referenced
this pull request
Sep 12, 2025
…ithastro#13759) Co-authored-by: jp-knj <[email protected]> Co-authored-by: Emanuele Stoppa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Errorthrows withAstroErrorinpackages/astro/src/content/loader/file.ts.Glob Pattern Errorfor disallowing*infile()loader paths.Parser Not Foundwhen no parser is available for the file extension.AstroErrorfromcore/errorsso all runtime errors funnel through our unified error-handling layer.pnpm exec changeset) to surface in release notes.Testing
pnpm test– all existing tests pass.data/*.jsonglob; verified the new Glob Pattern Error message surfaces in the terminal with the Astro error banner..xmlfile; saw the Parser Not Found message and helpful suggestion.No additional tests added because logic remains identical; only the error-reporting wrapper changed.
Docs
No user-facing API changes. Docs remain valid.